From mboxrd@z Thu Jan 1 00:00:00 1970 From: frowand.list@gmail.com (Frank Rowand) Date: Thu, 11 Feb 2016 10:10:49 -0800 Subject: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base In-Reply-To: <56BC6ABA.5020605@arm.com> References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> <56BC6ABA.5020605@arm.com> Message-ID: <56BCCEA9.4050509@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2/11/2016 3:04 AM, Marc Zyngier wrote: > On 09/02/16 11:04, Robin Murphy wrote: >> The existing msi-map code is fine for shifting the entire RID space >> upwards, but attempting finer-grained remapping reveals a bug. It turns >> out that we are mistakenly treating the msi-base part as an offset, not >> as a new base to remap onto, so things get squiffy when rid-base is >> nonzero. Fix this, and at the same time add a sanity check against >> having msi-map-mask clash with a nonzero rid-base, as that's another >> thing one can easily get wrong. >> >> CC: >> Signed-off-by: Robin Murphy > > Rob, Frank, > > Are you willing to take this one through the OF tree? Or should we route > it through the IRQ tree? It'd be good if it make it into 4.5. > > Thanks, > > M. > Just to be picky, I would like the patch to be split in two for easier bisecting, but if Rob is happy with a single patch I'm ok with that. Rob, will you pick this up? Acked-by: Frank Rowand -Frank