linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/7] arm64: dts: r8a7795: Add missing properties to CA57 L2 cache node
Date: Tue, 16 Feb 2016 09:43:35 +0000	[thread overview]
Message-ID: <56C2EF47.4080809@arm.com> (raw)
In-Reply-To: <56C2C471.80000@de.bosch.com>



On 16/02/16 06:40, Dirk Behme wrote:
> On 15.02.2016 21:38, Geert Uytterhoeven wrote:
>> Add the missing "cache-unified" and "cache-level" properties to the
>> Cortex-A57 cache-controller node.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> v3:
>>    - Remaining part of "[PATCH v2 6/6] arm64: renesas: r8a7795: Add L2
>>      cache-controller nodes", after dropping the "arm,data-latency" and
>>      "arm,tag-latency" properties.
>> ---
>>   arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index b5e46e4ff72ad003..c07f4e83b988ba42 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -68,6 +68,8 @@
>>
>>       L2_CA57: cache-controller at 0 {
>>           compatible = "cache";
>> +        cache-unified;
>> +        cache-level = <2>;
>
>
> As this is completely unused on ARMv8 I don't think that we want to have
> these unused entries in the DT.
>
> Sudeep: What do you think?
>

I am fine with that, I don't see any issue having them as they are
static values and highly unlikely to change and hence no threat to
backward compatibility.

The main concern I had with latency values is that it's currently not
used anywhere but if we decide to use say in secure software, having the
untested/early values in DT might cause compatibility issues in future
as they were added much before the actual understanding of it's usage.
So I prefer to defer them until then.

-- 
Regards,
Sudeep

  reply	other threads:[~2016-02-16  9:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 20:38 [PATCH v3 0/7] ARM/arm64: dts: renesas: Add/complete L2 cache-controller nodes Geert Uytterhoeven
2016-02-15 20:38 ` [PATCH v3 1/7] ARM: dts: r8a73a4: Add " Geert Uytterhoeven
2016-02-15 20:38 ` [PATCH v3 2/7] ARM: dts: r8a7790: " Geert Uytterhoeven
2016-02-15 20:38 ` [PATCH v3 3/7] ARM: dts: r8a7791: Add L2 cache-controller node Geert Uytterhoeven
2016-02-15 20:38 ` [PATCH v3 4/7] ARM: dts: r8a7793: " Geert Uytterhoeven
2016-02-15 20:38 ` [PATCH v3 5/7] ARM: dts: r8a7794: " Geert Uytterhoeven
2016-02-15 20:38 ` [PATCH v3 6/7] arm64: dts: r8a7795: Add missing properties to CA57 L2 cache node Geert Uytterhoeven
2016-02-16  6:40   ` Dirk Behme
2016-02-16  9:43     ` Sudeep Holla [this message]
2016-02-16  9:55       ` Dirk Behme
2016-02-15 20:38 ` [PATCH v3 7/7] arm64: dts: r8a7795: Add CA53 L2 cache-controller node Geert Uytterhoeven
2016-02-16  6:44   ` Dirk Behme
2016-02-16  7:12     ` Geert Uytterhoeven
2016-02-16  7:33       ` Dirk Behme
2016-02-16  9:46       ` Sudeep Holla
2016-02-17  5:53 ` [PATCH v3 0/7] ARM/arm64: dts: renesas: Add/complete L2 cache-controller nodes Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C2EF47.4080809@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).