linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: health/afe4403: select REGMAP_SPI
Date: Wed, 17 Feb 2016 19:32:09 +0000	[thread overview]
Message-ID: <56C4CAB9.8000609@kernel.org> (raw)
In-Reply-To: <56C34AF8.7080104@ti.com>

On 16/02/16 16:14, Andrew F. Davis wrote:
> On 02/16/2016 09:52 AM, Arnd Bergmann wrote:
>> The newly added afe4403 driver uses the regmap facility to abstract
>> the I2C and SPI access. However, it fails to ensure that regmap_spi
>> is actually present:
>>
>> drivers/iio/built-in.o: In function `afe4403_probe':
>> :(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'
>>
>> This adds a Kconfig select statement like the afe4404 I2C driver
>> has.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
>> ---
>>   drivers/iio/health/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig
>> index f0c19779ac27..c5f004a8e447 100644
>> --- a/drivers/iio/health/Kconfig
>> +++ b/drivers/iio/health/Kconfig
>> @@ -10,6 +10,7 @@ menu "Heart Rate Monitors"
>>   config AFE4403
>>       tristate "TI AFE4403 Heart Rate Monitor"
>>       depends on SPI_MASTER
>> +    select REGMAP_SPI
>>       select IIO_BUFFER
>>       select IIO_TRIGGERED_BUFFER
>>       help
>>
> 
> Oversight on my part, thanks for fix.
> 
> Acked-by: Andrew F. Davis <afd@ti.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to fail to trigger similar issues... (ah well, they can't
hammer everything!)

Thanks Arnd!

Jonathan

      reply	other threads:[~2016-02-17 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 15:52 [PATCH] iio: health/afe4403: select REGMAP_SPI Arnd Bergmann
2016-02-16 16:14 ` Andrew F. Davis
2016-02-17 19:32   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C4CAB9.8000609@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).