* [PATCH] iio: health/afe4403: select REGMAP_SPI
@ 2016-02-16 15:52 Arnd Bergmann
2016-02-16 16:14 ` Andrew F. Davis
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-02-16 15:52 UTC (permalink / raw)
To: linux-arm-kernel
The newly added afe4403 driver uses the regmap facility to abstract
the I2C and SPI access. However, it fails to ensure that regmap_spi
is actually present:
drivers/iio/built-in.o: In function `afe4403_probe':
:(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'
This adds a Kconfig select statement like the afe4404 I2C driver
has.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
---
drivers/iio/health/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig
index f0c19779ac27..c5f004a8e447 100644
--- a/drivers/iio/health/Kconfig
+++ b/drivers/iio/health/Kconfig
@@ -10,6 +10,7 @@ menu "Heart Rate Monitors"
config AFE4403
tristate "TI AFE4403 Heart Rate Monitor"
depends on SPI_MASTER
+ select REGMAP_SPI
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
help
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] iio: health/afe4403: select REGMAP_SPI
2016-02-16 15:52 [PATCH] iio: health/afe4403: select REGMAP_SPI Arnd Bergmann
@ 2016-02-16 16:14 ` Andrew F. Davis
2016-02-17 19:32 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Andrew F. Davis @ 2016-02-16 16:14 UTC (permalink / raw)
To: linux-arm-kernel
On 02/16/2016 09:52 AM, Arnd Bergmann wrote:
> The newly added afe4403 driver uses the regmap facility to abstract
> the I2C and SPI access. However, it fails to ensure that regmap_spi
> is actually present:
>
> drivers/iio/built-in.o: In function `afe4403_probe':
> :(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'
>
> This adds a Kconfig select statement like the afe4404 I2C driver
> has.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
> ---
> drivers/iio/health/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig
> index f0c19779ac27..c5f004a8e447 100644
> --- a/drivers/iio/health/Kconfig
> +++ b/drivers/iio/health/Kconfig
> @@ -10,6 +10,7 @@ menu "Heart Rate Monitors"
> config AFE4403
> tristate "TI AFE4403 Heart Rate Monitor"
> depends on SPI_MASTER
> + select REGMAP_SPI
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
>
Oversight on my part, thanks for fix.
Acked-by: Andrew F. Davis <afd@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] iio: health/afe4403: select REGMAP_SPI
2016-02-16 16:14 ` Andrew F. Davis
@ 2016-02-17 19:32 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-02-17 19:32 UTC (permalink / raw)
To: linux-arm-kernel
On 16/02/16 16:14, Andrew F. Davis wrote:
> On 02/16/2016 09:52 AM, Arnd Bergmann wrote:
>> The newly added afe4403 driver uses the regmap facility to abstract
>> the I2C and SPI access. However, it fails to ensure that regmap_spi
>> is actually present:
>>
>> drivers/iio/built-in.o: In function `afe4403_probe':
>> :(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'
>>
>> This adds a Kconfig select statement like the afe4404 I2C driver
>> has.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
>> ---
>> drivers/iio/health/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig
>> index f0c19779ac27..c5f004a8e447 100644
>> --- a/drivers/iio/health/Kconfig
>> +++ b/drivers/iio/health/Kconfig
>> @@ -10,6 +10,7 @@ menu "Heart Rate Monitors"
>> config AFE4403
>> tristate "TI AFE4403 Heart Rate Monitor"
>> depends on SPI_MASTER
>> + select REGMAP_SPI
>> select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> help
>>
>
> Oversight on my part, thanks for fix.
>
> Acked-by: Andrew F. Davis <afd@ti.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to fail to trigger similar issues... (ah well, they can't
hammer everything!)
Thanks Arnd!
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-17 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-16 15:52 [PATCH] iio: health/afe4403: select REGMAP_SPI Arnd Bergmann
2016-02-16 16:14 ` Andrew F. Davis
2016-02-17 19:32 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).