public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420
Date: Fri, 19 Feb 2016 12:51:48 +0900	[thread overview]
Message-ID: <56C69154.40608@samsung.com> (raw)
In-Reply-To: <87h9h599zi.fsf@e105922-lin.cambridge.arm.com>

On 19.02.2016 02:58, Punit Agrawal wrote:
> Hi Krzysztof,
> 
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> 
>> On Exynos5420 we support 8 cpufreq steps (600-1300 MHz) for LITTLE and
>> 12 steps for big core (700-1800 MHz). Add respective cooling cells.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> ---
>>
>> Changes since v1:
>> 1. Add cooling properties to all CPUs (suggested by Viresh).
>> ---
>>  arch/arm/boot/dts/exynos5420-cpus.dtsi | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi
>> index 261d25173f61..5c052d7ff554 100644
>> --- a/arch/arm/boot/dts/exynos5420-cpus.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi
>> @@ -33,6 +33,9 @@
>>  			clock-frequency = <1800000000>;
>>  			cci-control-port = <&cci_control1>;
>>  			operating-points-v2 = <&cluster_a15_opp_table>;
>> +			cooling-min-level = <0>;
>> +			cooling-max-level = <11>;
> 
> Although the above two properties are defined they aren't parsed in the
> kernel.
> 
> Setting min / max extents for cooling devices via cooling maps does work
> though.

It is described as optional property in
Documentation/devicetree/bindings/thermal/thermal.txt ... but indeed it
is totally ignored.

So what is the recommendation? Get rid of it from DTS and documentation
or leave it because it will be implemented someday?

Thanks for feedback!

Best regards,
Krzysztof

  reply	other threads:[~2016-02-19  3:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18  5:13 [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Krzysztof Kozlowski
2016-02-18  5:13 ` [PATCH v2 2/3] ARM: dts: Add cooling levels for CPUs on exynos5422/5800 Krzysztof Kozlowski
2016-02-18  6:21   ` Viresh Kumar
2016-02-18  5:13 ` [PATCH v2 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Krzysztof Kozlowski
2016-02-18  6:22   ` Viresh Kumar
2016-02-18  6:21 ` [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Viresh Kumar
2016-02-18 17:58 ` Punit Agrawal
2016-02-19  3:51   ` Krzysztof Kozlowski [this message]
2016-02-22 11:21     ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C69154.40608@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox