From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: EXYNOS: cleanup header files inclusion
Date: Tue, 23 Feb 2016 09:09:17 +0900 [thread overview]
Message-ID: <56CBA32D.4020905@samsung.com> (raw)
In-Reply-To: <1456135396-17767-4-git-send-email-pankaj.dubey@samsung.com>
On 22.02.2016 19:03, Pankaj Dubey wrote:
> This includes trivial cleanup in exynos files such as
> - remove unused header files inclusion from exynos.c, s5p-dev-mfc.c,
> firmware.c, pm.c.
> - move inclusion of of.h from common.h to pm.c where it is really
> required
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/common.h | 1 -
> arch/arm/mach-exynos/exynos.c | 5 -----
> arch/arm/mach-exynos/firmware.c | 2 --
> arch/arm/mach-exynos/platsmp.c | 1 -
> arch/arm/mach-exynos/pm.c | 4 +---
> arch/arm/mach-exynos/s5p-dev-mfc.c | 1 -
> 6 files changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index e349a03..5365bf1 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -12,7 +12,6 @@
> #ifndef __ARCH_ARM_MACH_EXYNOS_COMMON_H
> #define __ARCH_ARM_MACH_EXYNOS_COMMON_H
>
> -#include <linux/of.h>
> #include <linux/platform_data/cpuidle-exynos.h>
>
> #define EXYNOS3250_SOC_ID 0xE3472000
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index 99947ad..54262a1 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -11,14 +11,10 @@
>
> #include <linux/init.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> -#include <linux/serial_s3c.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_fdt.h>
> #include <linux/of_platform.h>
> -#include <linux/platform_device.h>
platform_device is actually used in that file. It looks unused because
it is pulled by of_platform, but it makes sense to include it here.
Rest looks good.
BR,
Krzysztof
next prev parent reply other threads:[~2016-02-23 0:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 10:03 [PATCH 0/3] ARM: EXYNOS: Trivial cleanup in mach-exynos Pankaj Dubey
2016-02-22 10:03 ` [PATCH 1/3] ARM: EXYNOS: correct header comment in Kconfig file Pankaj Dubey
2016-02-23 0:01 ` Krzysztof Kozlowski
2016-02-22 10:03 ` [PATCH 2/3] ARM: EXYNOS: remove unused register offset definition Pankaj Dubey
2016-02-23 0:03 ` Krzysztof Kozlowski
2016-02-23 9:11 ` pankaj.dubey
2016-02-23 23:47 ` Krzysztof Kozlowski
2016-02-24 8:23 ` pankaj.dubey
2016-02-24 9:14 ` Krzysztof Kozlowski
2016-02-22 10:03 ` [PATCH 3/3] ARM: EXYNOS: cleanup header files inclusion Pankaj Dubey
2016-02-23 0:09 ` Krzysztof Kozlowski [this message]
2016-02-23 9:17 ` pankaj.dubey
2016-02-24 1:02 ` Krzysztof Kozlowski
2016-02-24 4:01 ` pankaj.dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CBA32D.4020905@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).