From mboxrd@z Thu Jan 1 00:00:00 1970 From: ldewangan@nvidia.com (Laxman Dewangan) Date: Wed, 24 Feb 2016 22:44:52 +0530 Subject: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister} In-Reply-To: <771728522.222286.b52ca77e-fe5e-4536-8e14-525e9a846cdc.open-xchange@email.1und1.de> References: <1456319775-3216-1-git-send-email-ldewangan@nvidia.com> <771728522.222286.b52ca77e-fe5e-4536-8e14-525e9a846cdc.open-xchange@email.1und1.de> Message-ID: <56CDE50C.4050504@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 24 February 2016 10:52 PM, Stefan Wahren wrote: > Hi Laxman, > >> Laxman Dewangan hat am 24. Februar 2016 um 14:15 >> geschrieben: >> >> >> Add resource manageemnt APIs fro pinctrl_register() and pinctrl_unregister() >> and use these new APIs on hw driver to reduce the error path code and >> remove callback for driver. >> > just for interest: why didn't you patch freescale/pinctrl-mxs.c? > The remove callback is implemented as: int mxs_pinctrl_remove(struct platform_device *pdev) { struct mxs_pinctrl_data *d = platform_get_drvdata(pdev); pinctrl_unregister(d->pctl); iounmap(d->base); return 0; } So if I use devm_pinctrl_register() then the sequence will be different like iounmap() pinctrl_unregister() And I did not want to change the sequence as dont know the side effect until I test it on actual platform which is not there with me.