linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: akshay.bhat@timesys.com (Akshay Bhat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] ARM: imx6: Fix procedure to switch the parent of, LDB_DI_CLK
Date: Thu, 25 Feb 2016 14:49:16 -0500	[thread overview]
Message-ID: <56CF5ABC.8040109@timesys.com> (raw)
In-Reply-To: 1453461088-31549-4-git-send-email-p.zabel@pengutronix.de

Hi Fabio, Phillip,

Philipp Zabel <p.zabel <at> pengutronix.de> writes:

 >
 > From: Fabio Estevam <fabio.estevam <at> freescale.com>
 >

<snip>
 > +		sel[i][2] = sel[i][3] | 4;
 > +
 > +		pr_debug("ccm: switching ldb_di0_sel: %d->%d->%d->%d\n",
 > +			 sel[i][0], sel[i][1], sel[i][2], sel[i][3]);

Change ldb_di0_sel to ldb_di%d_sel

<snip>

 > +	if (sel[0][0] == sel[0][3] && sel[1][0] == sel[1][3])
 > +		return;
 > +
 > +	mmdc_ch1_disable(ccm_base);
 > +
 > +	for (i = 1; i < 4; i++) {
 > +		reg = readl_relaxed(ccm_base + CCM_CS2CDR);
 > +		reg &= ~((7 << CS2CDR_LDB_DI0_CLK_SEL_SHIFT) |
 > +			 (7 << CS2CDR_LDB_DI1_CLK_SEL_SHIFT));
 > +		reg |= ((sel[0][i] << CS2CDR_LDB_DI0_CLK_SEL_SHIFT) |
 > +			(sel[1][i] << CS2CDR_LDB_DI0_CLK_SEL_SHIFT));

Needs to be CS2CDR_LDB_DI1_CLK_SEL_SHIFT in the last line; otherwise the 
ldb_di1_clock is set to have incorrect source.

With the above change the patch works great for me. Without this patch 
we were having an issue on some boards where the LVDS would lockup 
sometimes when the clock source was being changed. This patch fixes our 
issue.

Thanks,
Akshay

             reply	other threads:[~2016-02-25 19:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 19:49 Akshay Bhat [this message]
2016-02-26  8:48 ` [PATCH v3 3/3] ARM: imx6: Fix procedure to switch the parent of, LDB_DI_CLK Philipp Zabel
  -- strict thread matches above, loose matches on Subject: below --
2016-01-22 11:11 [PATCH v3 0/3] i.MX6 LDB mux/divider glitch workaround Philipp Zabel
2016-01-22 11:11 ` [PATCH v3 3/3] ARM: imx6: Fix procedure to switch the parent of LDB_DI_CLK Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF5ABC.8040109@timesys.com \
    --to=akshay.bhat@timesys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).