From: phil@raspberrypi.org (Phil Elwell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
Date: Tue, 1 Mar 2016 09:13:01 +0000 [thread overview]
Message-ID: <56D55D1D.8090701@raspberrypi.org> (raw)
In-Reply-To: <1456795808-1449-1-git-send-email-eric@anholt.net>
On 01/03/2016 01:30, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable at vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
>
> Phil, any chance you could start putting Signed-off-by lines on your
> kernel commits?
>
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 0f5997c..08b1d93 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -779,7 +779,7 @@ static int bcm2835_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
> }
> if (num_pulls) {
> err = of_property_read_u32_index(np, "brcm,pull",
> - (num_funcs > 1) ? i : 0, &pull);
> + (num_pulls > 1) ? i : 0, &pull);
> if (err)
> goto out;
> err = bcm2835_pctl_dt_node_to_map_pull(pc, np, pin,
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
next prev parent reply other threads:[~2016-03-01 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 1:30 [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing Eric Anholt
2016-03-01 9:13 ` Phil Elwell [this message]
2016-03-03 21:09 ` Stephen Warren
2016-03-08 8:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D55D1D.8090701@raspberrypi.org \
--to=phil@raspberrypi.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).