From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines
Date: Fri, 4 Mar 2016 08:27:26 +0100 [thread overview]
Message-ID: <56D938DE.10409@redhat.com> (raw)
In-Reply-To: <20160304043559.GA21743@kroah.com>
Hi,
On 04-03-16 05:35, Greg Kroah-Hartman wrote:
> On Sat, Feb 27, 2016 at 05:58:58PM +0100, Hans de Goede wrote:
>> From: Reinder de Haan <patchesrdh@mveas.com>
>>
>> At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple
>> reset lines, the controller will not initialize while the reset for
>> its companion is still asserted, which means we need to de-assert
>> 2 resets for the controller to work.
>>
>> Signed-off-by: Reinder de Haan <patchesrdh@mveas.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>> Changes in v2:
>> -Use the new reset_control_[de]assert_shared reset-controller functions
>> Changes in v3:
>> -Adjust for changes to shared-reset reset-controller functions
>> Changes in v4:
>> -Fix Ugly continuation line
>
> This breaks the build horribly :(
>
> As does patch 2/2, ugh.
As said in the cover letter:
"These patches apply on top of the related
reset-controller patches which have just been merged here:
git://git.pengutronix.de/git/pza/linux.git reset/next"
I guess I should have done s/apply on top of/depend on/
in the above bit. These patches apply fine without those
changes, but indeed they will not build.
You may want to ask Philipp Zabel (added to the To: list)
to create a topic branch for this which you can merge into
your tree.
Regards,
Hans
next prev parent reply other threads:[~2016-03-04 7:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 16:58 [PATCH v4 0/2] ?hci-platform: Add support for controllers with more then one reset line Hans de Goede
2016-02-27 16:58 ` [PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines Hans de Goede
2016-03-03 22:13 ` Rob Herring
2016-03-04 4:35 ` Greg Kroah-Hartman
2016-03-04 7:27 ` Hans de Goede [this message]
2016-03-05 20:02 ` [linux-sunxi] " Greg Kroah-Hartman
2016-03-08 10:53 ` Hans de Goede
2016-03-05 22:45 ` kbuild test robot
2016-02-27 16:58 ` [PATCH v4 2/2] ohci-platform: " Hans de Goede
2016-03-03 22:14 ` Rob Herring
2016-03-05 22:58 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D938DE.10409@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).