From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example
Date: Tue, 8 Mar 2016 11:16:30 +0100 [thread overview]
Message-ID: <56DEA67E.8090704@suse.de> (raw)
In-Reply-To: <525564DD-D0D3-4DEB-9306-3A23288FD83F@gmail.com>
Am 08.03.2016 um 10:41 schrieb Julien Chauveau:
> Le 8 mars 2016 ? 09:54, Geert Uytterhoeven <geert@linux-m68k.org> a ?crit :
>> On Mon, Mar 7, 2016 at 7:24 PM, Andreas F?rber <afaerber@suse.de> wrote:
>>> Drop #address-cells and #size-cells, which are not required by the
>>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>>
>>> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
>>> Signed-off-by: Andreas F?rber <afaerber@suse.de>
>>> ---
>>> Documentation/devicetree/bindings/input/gpio-keys.txt | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
>>> index 21641236c095..1552a11f6786 100644
>>> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
>>> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
>>> @@ -34,8 +34,6 @@ Example nodes:
>>>
>>> gpio_keys {
>>> compatible = "gpio-keys";
>>> - #address-cells = <1>;
>>> - #size-cells = <0>;
>>> autorepeat;
>>> button at 21 {
>>
>> FYI, with "[PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd":
>> (http://www.spinics.net/lists/devicetree/msg117206.html) applied:
>>
>> Warning (unit_address_vs_reg): Node /keyboard/button at 21 has a unit
>> name, but no reg property
>>
>
> Hi Andreas,
> This means you can also drop the unit-address (the @21 part) for the button.
> What about using a more relevant name like "key_up" instead of "button"?
Or in my case power-key or power-button. Or would just power suffice?
The Landingship baseboard does have four more buttons not yet enabled,
so I do need some way to distinguish nodes.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2016-03-08 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 18:24 [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example Andreas Färber
2016-03-07 18:34 ` Javier Martinez Canillas
2016-03-07 19:25 ` Andreas Färber
2016-03-08 8:54 ` Geert Uytterhoeven
2016-03-08 9:41 ` Julien Chauveau
2016-03-08 10:16 ` Andreas Färber [this message]
2016-03-10 23:08 ` Julien Chauveau
2016-03-08 10:09 ` Andreas Färber
2016-03-10 23:08 ` Julien Chauveau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEA67E.8090704@suse.de \
--to=afaerber@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox