From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] ARM: dts: Add rtc and adc dt node for exynos3250-artik5 module
Date: Mon, 14 Mar 2016 16:21:08 +0900 [thread overview]
Message-ID: <56E66664.3020405@samsung.com> (raw)
In-Reply-To: <56E66462.9000402@samsung.com>
On 2016? 03? 14? 16:12, Krzysztof Kozlowski wrote:
> On 14.03.2016 11:04, Chanwoo Choi wrote:
>> This patch adds the RTC (Real Time Clock) and ADC (Analog Digital Converter)
>> Device Tree node for exynos3250-artik5 module. The RTC is used for wakeup
>> source and the ADC is used to read the analog data such as battery temperature.
>>
>> ADC need to connect the some H/W device such as battery. So, this patch just
>> adds the default setting (clock, regulator).
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos3250-artik5.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
>> index 877e4827df83..673883fda480 100644
>> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
>> @@ -48,6 +48,12 @@
>> };
>> };
>>
>> +&adc {
>> + vdd-supply = <&ldo7_reg>;
>> + assigned-clocks = <&cmu CLK_SCLK_TSADC>;
>> + assigned-clock-rates = <6000000>;
>> +};
>
> No thermistors, status non-okay. What is provided here?
The some device are not connected for ADC line on artik5-eval board.
This dt node just initialize the basic setting (clock,regulator) ADC of exynos3250 SoC.
(I'll change the board name from artik5-devel to artik5-eval on v2 patchset)
The vdd-supply for ADC is already fixed on artik5 module.
>
>> +
>> &cpu0 {
>> cpu0-supply = <&buck2_reg>;
>> };
>> @@ -319,6 +325,12 @@
>> status = "okay";
>> };
>>
>> +&rtc {
>> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> + clock-names = "rtc", "rtc_src";
>> + status = "okay";
>> +};
>
> Same comment as for previous patch - just squash it. Splitting brings no
> benefits and makes it more difficult to see bigger picture.
Okay. I'll merge it with 5/10 patch.
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2016-03-14 7:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 2:04 [PATCH 00/10] ARM: dts: Add new Exynos3250-based ARTIK5 module dtsi file Chanwoo Choi
2016-03-14 2:04 ` [PATCH 01/10] clk: samsung: exynos3250: Add UART2 clock Chanwoo Choi
2016-03-14 2:04 ` [PATCH 02/10] clk: samsung: exynos3250: Add MMC2 clock Chanwoo Choi
2016-03-14 2:04 ` [PATCH 03/10] ARM: dts: Add UART2 dt node for Exynos3250 SoC Chanwoo Choi
2016-03-14 2:04 ` [PATCH 04/10] ARM: dts: Add MSHC2 " Chanwoo Choi
2016-03-14 6:22 ` Krzysztof Kozlowski
2016-03-14 8:28 ` Chanwoo Choi
2016-03-14 9:52 ` Krzysztof Kozlowski
2016-03-14 2:04 ` [PATCH 05/10] ARM: dts: Add exynos3250-artik5 dtsi file for ARTIK5 module Chanwoo Choi
2016-03-14 6:42 ` Krzysztof Kozlowski
2016-03-14 6:57 ` Chanwoo Choi
2016-03-14 7:22 ` Chanwoo Choi
2016-03-14 2:04 ` [PATCH 06/10] ARM: dts: Add MSHC0 dt node for eMMC device for exynos3250-artik5 module Chanwoo Choi
2016-03-14 6:57 ` Krzysztof Kozlowski
2016-03-14 8:15 ` Chanwoo Choi
2016-03-14 9:59 ` Krzysztof Kozlowski
2016-03-14 2:04 ` [PATCH 06/10] ARM: dts: exynos3250-artik5: Add MSHC0 dt node for eMMC device Chanwoo Choi
2016-03-14 2:10 ` Chanwoo Choi
2016-03-14 2:04 ` [PATCH 07/10] ARM: dts: Add thermal zone and cpufreq node for exynos3250-artik5 module Chanwoo Choi
2016-03-14 7:06 ` Krzysztof Kozlowski
2016-03-14 7:13 ` Chanwoo Choi
2016-03-14 2:04 ` [PATCH 08/10] ARM: dts: Add rtc and adc dt " Chanwoo Choi
2016-03-14 7:12 ` Krzysztof Kozlowski
2016-03-14 7:21 ` Chanwoo Choi [this message]
2016-03-14 2:04 ` [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board Chanwoo Choi
2016-03-14 8:31 ` Krzysztof Kozlowski
2016-03-14 8:48 ` Chanwoo Choi
2016-03-14 9:44 ` Krzysztof Kozlowski
2016-03-14 10:22 ` Chanwoo Choi
2016-03-15 0:25 ` Krzysztof Kozlowski
2016-03-15 0:56 ` Jaehoon Chung
2016-03-15 1:45 ` Chanwoo Choi
2016-03-15 1:46 ` Chanwoo Choi
2016-03-14 2:04 ` [PATCH 10/10] ARM: dts: Add PPMU node for exynos3250-artik5 module Chanwoo Choi
2016-03-14 8:34 ` Krzysztof Kozlowski
2016-03-14 8:43 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E66664.3020405@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).