linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default
       [not found] <20160314042700.596192247@telegraphics.com.au>
@ 2016-03-14  4:27 ` Finn Thain
  2016-03-14  7:26   ` Hannes Reinecke
  2016-03-14  4:27 ` [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro Finn Thain
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Finn Thain @ 2016-03-14  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-FLAG_DMA_FIXUP
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/11fb0d48/attachment.ksh>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro
       [not found] <20160314042700.596192247@telegraphics.com.au>
  2016-03-14  4:27 ` [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default Finn Thain
@ 2016-03-14  4:27 ` Finn Thain
  2016-03-14  7:28   ` Hannes Reinecke
  2016-03-14  4:27 ` [PATCH 08/22] ncr5380: Use DMA hooks for PDMA Finn Thain
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Finn Thain @ 2016-03-14  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-PSEUDO_DMA-macro
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/32852948/attachment.ksh>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 08/22] ncr5380: Use DMA hooks for PDMA
       [not found] <20160314042700.596192247@telegraphics.com.au>
  2016-03-14  4:27 ` [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default Finn Thain
  2016-03-14  4:27 ` [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro Finn Thain
@ 2016-03-14  4:27 ` Finn Thain
  2016-03-14  7:34   ` Hannes Reinecke
  2016-03-14  4:27 ` [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention Finn Thain
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Finn Thain @ 2016-03-14  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-rename-pread-and-pwrite
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/a2dcfacb/attachment.ksh>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention
       [not found] <20160314042700.596192247@telegraphics.com.au>
                   ` (2 preceding siblings ...)
  2016-03-14  4:27 ` [PATCH 08/22] ncr5380: Use DMA hooks for PDMA Finn Thain
@ 2016-03-14  4:27 ` Finn Thain
  2016-03-14  7:36   ` Hannes Reinecke
  2016-03-14  4:27 ` [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver Finn Thain
  2016-03-14  4:27 ` [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros Finn Thain
  5 siblings, 1 reply; 14+ messages in thread
From: Finn Thain @ 2016-03-14  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-dma-setup-api
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/943f0008/attachment.ksh>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver
       [not found] <20160314042700.596192247@telegraphics.com.au>
                   ` (3 preceding siblings ...)
  2016-03-14  4:27 ` [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention Finn Thain
@ 2016-03-14  4:27 ` Finn Thain
  2016-03-14  7:38   ` Hannes Reinecke
  2016-03-14  4:27 ` [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros Finn Thain
  5 siblings, 1 reply; 14+ messages in thread
From: Finn Thain @ 2016-03-14  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-merge-atari-dma-algorithm
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/0aeb10b2/attachment.ksh>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros
       [not found] <20160314042700.596192247@telegraphics.com.au>
                   ` (4 preceding siblings ...)
  2016-03-14  4:27 ` [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver Finn Thain
@ 2016-03-14  4:27 ` Finn Thain
  2016-03-14  7:47   ` Hannes Reinecke
  5 siblings, 1 reply; 14+ messages in thread
From: Finn Thain @ 2016-03-14  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-DONT_USE_INTR-and-AUTOPROBE_IRQ-macros
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/ae331683/attachment.ksh>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default
  2016-03-14  4:27 ` [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default Finn Thain
@ 2016-03-14  7:26   ` Hannes Reinecke
  0 siblings, 0 replies; 14+ messages in thread
From: Hannes Reinecke @ 2016-03-14  7:26 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/14/2016 05:27 AM, Finn Thain wrote:
> The only chip that needs the workarounds enabled is an early NMOS
> device. That means that the common case is to disable them.
> 
> Unfortunately the sense of the flag is such that it has to be set
> for the common case.
> 
> Rename the flag so that zero can be used to mean "no errata workarounds
> needed". This simplifies the code.
> 
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c      |   14 +++++++-------
>  drivers/scsi/NCR5380.h      |    2 +-
>  drivers/scsi/arm/cumana_1.c |    2 +-
>  drivers/scsi/arm/oak.c      |    2 +-
>  drivers/scsi/dtc.c          |    2 +-
>  drivers/scsi/g_NCR5380.c    |    8 +-------
>  drivers/scsi/pas16.c        |    2 +-
>  drivers/scsi/t128.c         |    2 +-
>  8 files changed, 14 insertions(+), 20 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro
  2016-03-14  4:27 ` [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro Finn Thain
@ 2016-03-14  7:28   ` Hannes Reinecke
  0 siblings, 0 replies; 14+ messages in thread
From: Hannes Reinecke @ 2016-03-14  7:28 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/14/2016 05:27 AM, Finn Thain wrote:
> For those wrapper drivers which only implement Programmed IO, have
> NCR5380_dma_xfer_len() evaluate to zero. That allows PDMA to be easily
> disabled at run-time and so the PSEUDO_DMA macro is no longer needed.
> 
> Also remove the spin counters used for debugging pseudo DMA drivers.
> 
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c      |   32 +-------------------------------
>  drivers/scsi/NCR5380.h      |    4 ----
>  drivers/scsi/arm/cumana_1.c |    2 --
>  drivers/scsi/arm/oak.c      |    3 +--
>  drivers/scsi/dmx3191d.c     |    4 ++++
>  drivers/scsi/dtc.c          |    7 -------
>  drivers/scsi/dtc.h          |    2 --
>  drivers/scsi/g_NCR5380.c    |    1 -
>  drivers/scsi/g_NCR5380.h    |    1 -
>  drivers/scsi/mac_scsi.c     |   10 ----------
>  drivers/scsi/pas16.c        |   10 ----------
>  drivers/scsi/pas16.h        |    2 --
>  drivers/scsi/t128.c         |    4 ----
>  drivers/scsi/t128.h         |    2 --
>  14 files changed, 6 insertions(+), 78 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 08/22] ncr5380: Use DMA hooks for PDMA
  2016-03-14  4:27 ` [PATCH 08/22] ncr5380: Use DMA hooks for PDMA Finn Thain
@ 2016-03-14  7:34   ` Hannes Reinecke
  0 siblings, 0 replies; 14+ messages in thread
From: Hannes Reinecke @ 2016-03-14  7:34 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/14/2016 05:27 AM, Finn Thain wrote:
> Those wrapper drivers which use DMA define the REAL_DMA macro and
> those which use pseudo DMA define PSEUDO_DMA. These macros need to be
> removed for a number of reasons, not least of which is to have drivers
> share more code.
> 
> Redefine the PDMA send and receive hooks as DMA setup hooks, so that the
> DMA code can be shared by all 5380 wrapper drivers. This will help to
> reunify the forked core driver.
> 
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c      |   10 ++--------
>  drivers/scsi/arm/cumana_1.c |   10 ++++++----
>  drivers/scsi/arm/oak.c      |   10 ++++++----
>  drivers/scsi/dmx3191d.c     |    4 ++--
>  drivers/scsi/dtc.c          |    6 ++++--
>  drivers/scsi/dtc.h          |    2 ++
>  drivers/scsi/g_NCR5380.c    |   10 ++++++----
>  drivers/scsi/g_NCR5380.h    |    4 ++--
>  drivers/scsi/mac_scsi.c     |    5 ++---
>  drivers/scsi/pas16.c        |   14 ++++++++------
>  drivers/scsi/pas16.h        |    2 ++
>  drivers/scsi/t128.c         |   12 ++++++------
>  drivers/scsi/t128.h         |    2 ++
>  13 files changed, 50 insertions(+), 41 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention
  2016-03-14  4:27 ` [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention Finn Thain
@ 2016-03-14  7:36   ` Hannes Reinecke
  2016-03-15  3:19     ` Finn Thain
  0 siblings, 1 reply; 14+ messages in thread
From: Hannes Reinecke @ 2016-03-14  7:36 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/14/2016 05:27 AM, Finn Thain wrote:
> Standardize the DMA setup hooks so that the DMA implementation in
> atari_NCR5380.c can be reconciled with pseudo DMA implementation in
> NCR5380.c.
> 
> Calls to NCR5380_dma_recv_setup() and NCR5380_dma_send_setup() return
> a negative value on failure, zero on PDMA transfer success and a positive
> byte count for DMA setup success.
> 
> This convention is not entirely new, but is now applied consistently.
> 
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c      |   21 ++++++++++-----------
>  drivers/scsi/arm/cumana_1.c |   10 ++++++++--
>  drivers/scsi/arm/oak.c      |    4 ++--
>  drivers/scsi/atari_scsi.c   |    3 ---
>  4 files changed, 20 insertions(+), 18 deletions(-)
> 
> Index: linux/drivers/scsi/NCR5380.c
> ===================================================================
> --- linux.orig/drivers/scsi/NCR5380.c	2016-03-14 15:26:34.000000000 +1100
> +++ linux/drivers/scsi/NCR5380.c	2016-03-14 15:26:37.000000000 +1100
> @@ -1431,7 +1431,7 @@ static int NCR5380_transfer_dma(struct S
>  	register unsigned char p = *phase;
>  	register unsigned char *d = *data;
>  	unsigned char tmp;
> -	int foo;
> +	int result;
>  
>  	if ((tmp = (NCR5380_read(STATUS_REG) & PHASE_MASK)) != p) {
>  		*phase = tmp;
> @@ -1505,9 +1505,9 @@ static int NCR5380_transfer_dma(struct S
>   */
>  
>  	if (p & SR_IO) {
> -		foo = NCR5380_dma_recv_setup(instance, d,
> +		result = NCR5380_dma_recv_setup(instance, d,
>  			hostdata->flags & FLAG_DMA_FIXUP ? c - 1 : c);
> -		if (!foo && (hostdata->flags & FLAG_DMA_FIXUP)) {
> +		if (!result && (hostdata->flags & FLAG_DMA_FIXUP)) {
>  			/*
>  			 * The workaround was to transfer fewer bytes than we
>  			 * intended to with the pseudo-DMA read function, wait for
> @@ -1525,19 +1525,19 @@ static int NCR5380_transfer_dma(struct S
>  
>  			if (NCR5380_poll_politely(instance, BUS_AND_STATUS_REG,
>  			                          BASR_DRQ, BASR_DRQ, HZ) < 0) {
> -				foo = -1;
> +				result = -1;
>  				shost_printk(KERN_ERR, instance, "PDMA read: DRQ timeout\n");
>  			}
>  			if (NCR5380_poll_politely(instance, STATUS_REG,
>  			                          SR_REQ, 0, HZ) < 0) {
> -				foo = -1;
> +				result = -1;
>  				shost_printk(KERN_ERR, instance, "PDMA read: !REQ timeout\n");
>  			}
>  			d[c - 1] = NCR5380_read(INPUT_DATA_REG);
>  		}
>  	} else {
> -		foo = NCR5380_dma_send_setup(instance, d, c);
> -		if (!foo && (hostdata->flags & FLAG_DMA_FIXUP)) {
> +		result = NCR5380_dma_send_setup(instance, d, c);
> +		if (!result && (hostdata->flags & FLAG_DMA_FIXUP)) {
>  			/*
>  			 * Wait for the last byte to be sent.  If REQ is being asserted for
>  			 * the byte we're interested, we'll ACK it and it will go false.
> @@ -1545,7 +1545,7 @@ static int NCR5380_transfer_dma(struct S
>  			if (NCR5380_poll_politely2(instance,
>  			     BUS_AND_STATUS_REG, BASR_DRQ, BASR_DRQ,
>  			     BUS_AND_STATUS_REG, BASR_PHASE_MATCH, 0, HZ) < 0) {
> -				foo = -1;
> +				result = -1;
>  				shost_printk(KERN_ERR, instance, "PDMA write: DRQ and phase timeout\n");
>  			}
>  		}
> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S
>  	NCR5380_read(RESET_PARITY_INTERRUPT_REG);
>  	*data = d + c;
>  	*count = 0;
> -	*phase = NCR5380_read(STATUS_REG) & PHASE_MASK;
> -	return foo;
> +	return result;
>  }
>  
>  /*

Don't you miss a phase update here?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver
  2016-03-14  4:27 ` [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver Finn Thain
@ 2016-03-14  7:38   ` Hannes Reinecke
  0 siblings, 0 replies; 14+ messages in thread
From: Hannes Reinecke @ 2016-03-14  7:38 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/14/2016 05:27 AM, Finn Thain wrote:
> Adopt the DMA implementation from atari_NCR5380.c. This means that
> atari_scsi and sun3_scsi can make use of the NCR5380.c core driver
> and the atari_NCR5380.c driver fork can be made redundant.
> 
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c      |  170 +++++++++++++++++++++++++++++++++++---------
>  drivers/scsi/arm/cumana_1.c |    3 
>  drivers/scsi/arm/oak.c      |    3 
>  drivers/scsi/dmx3191d.c     |    1 
>  drivers/scsi/dtc.c          |    2 
>  drivers/scsi/dtc.h          |    1 
>  drivers/scsi/g_NCR5380.c    |    2 
>  drivers/scsi/g_NCR5380.h    |    1 
>  drivers/scsi/mac_scsi.c     |    3 
>  drivers/scsi/pas16.c        |    2 
>  drivers/scsi/pas16.h        |    1 
>  drivers/scsi/t128.c         |    2 
>  drivers/scsi/t128.h         |    1 
>  13 files changed, 152 insertions(+), 40 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros
  2016-03-14  4:27 ` [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros Finn Thain
@ 2016-03-14  7:47   ` Hannes Reinecke
  0 siblings, 0 replies; 14+ messages in thread
From: Hannes Reinecke @ 2016-03-14  7:47 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/14/2016 05:27 AM, Finn Thain wrote:
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c   |   12 +-----------
>  drivers/scsi/NCR5380.h   |    4 ----
>  drivers/scsi/arm/oak.c   |    2 --
>  drivers/scsi/dmx3191d.c  |    2 --
>  drivers/scsi/dtc.c       |   12 +++---------
>  drivers/scsi/g_NCR5380.c |    2 --
>  drivers/scsi/pas16.c     |    1 -
>  drivers/scsi/t128.c      |    1 -
>  8 files changed, 4 insertions(+), 32 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention
  2016-03-14  7:36   ` Hannes Reinecke
@ 2016-03-15  3:19     ` Finn Thain
  2016-03-15  6:49       ` Hannes Reinecke
  0 siblings, 1 reply; 14+ messages in thread
From: Finn Thain @ 2016-03-15  3:19 UTC (permalink / raw)
  To: linux-arm-kernel


On Mon, 14 Mar 2016, Hannes Reinecke wrote:

> > @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S
> >  	NCR5380_read(RESET_PARITY_INTERRUPT_REG);
> >  	*data = d + c;
> >  	*count = 0;
> > -	*phase = NCR5380_read(STATUS_REG) & PHASE_MASK;
> > -	return foo;
> > +	return result;
> >  }
> >  
> >  /*
> 
> Don't you miss a phase update here?

I guess I missed explaining the change in the commit log.

The *phase assignment is redundant because after NCR5380_transfer_dma() 
returns control to NCR5380_information_transfer(), the latter routine then 
also returns, and so *phase is dead.

-- 

> 
> Cheers,
> 
> Hannes
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention
  2016-03-15  3:19     ` Finn Thain
@ 2016-03-15  6:49       ` Hannes Reinecke
  0 siblings, 0 replies; 14+ messages in thread
From: Hannes Reinecke @ 2016-03-15  6:49 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/15/2016 04:19 AM, Finn Thain wrote:
> 
> On Mon, 14 Mar 2016, Hannes Reinecke wrote:
> 
>>> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S
>>>  	NCR5380_read(RESET_PARITY_INTERRUPT_REG);
>>>  	*data = d + c;
>>>  	*count = 0;
>>> -	*phase = NCR5380_read(STATUS_REG) & PHASE_MASK;
>>> -	return foo;
>>> +	return result;
>>>  }
>>>  
>>>  /*
>>
>> Don't you miss a phase update here?
> 
> I guess I missed explaining the change in the commit log.
> 
> The *phase assignment is redundant because after NCR5380_transfer_dma() 
> returns control to NCR5380_information_transfer(), the latter routine then 
> also returns, and so *phase is dead.
> 
Right. Please add this to the commit message.

Otherwise:

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-03-15  6:49 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160314042700.596192247@telegraphics.com.au>
2016-03-14  4:27 ` [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default Finn Thain
2016-03-14  7:26   ` Hannes Reinecke
2016-03-14  4:27 ` [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro Finn Thain
2016-03-14  7:28   ` Hannes Reinecke
2016-03-14  4:27 ` [PATCH 08/22] ncr5380: Use DMA hooks for PDMA Finn Thain
2016-03-14  7:34   ` Hannes Reinecke
2016-03-14  4:27 ` [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention Finn Thain
2016-03-14  7:36   ` Hannes Reinecke
2016-03-15  3:19     ` Finn Thain
2016-03-15  6:49       ` Hannes Reinecke
2016-03-14  4:27 ` [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver Finn Thain
2016-03-14  7:38   ` Hannes Reinecke
2016-03-14  4:27 ` [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros Finn Thain
2016-03-14  7:47   ` Hannes Reinecke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).