From: majun258@huawei.com (majun (F))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] Irq/mbigen:Change the mbigen node definition in dt binding file
Date: Tue, 15 Mar 2016 15:35:47 +0800 [thread overview]
Message-ID: <56E7BB53.3060705@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1603140844490.3657@nanos>
Hi Thomas:
Thanks for pointing out the problems.
I'll make detail description about this problem and resend this patch set.
? 2016/3/14 15:49, Thomas Gleixner ??:
> Majun,
>
> On Mon, 14 Mar 2016, MaJun wrote:
>
> First of all the prefix for irq chip drivers is not "Irq/".
>
> Hint: git log drivers/irqchip
>
>> From: Ma Jun <majun258@huawei.com>
>>
>> For mbigen module, there is a special case that more than one mbigen
>> device nodes use the same reg definition in DTS when these devices
>> exist in the same mbigen hardware module.
>
> There is a special case, so what?
>
In current driver, the registers would be remapped repeatedly
and caused error when use the function "devm_ioremap_resource".
That's the problem I tried to fix.
>> To fix the mbigen IO remap problem, the mbigen node definition and
>
> Which problem?
>
>> structure are changed based on Mark Rutland's suggestion.
>
> That's really uselss. Nobody has any idea what Mark suggested and in which way
> it fixes that unspecified problem you are talking about.
>
Actually, I discussed this problem with Mark in v1.
He raised some questions and suggestions
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/403691.html
Thanks!
MaJun
> Thanks,
>
> tglx
>
> .
>
next prev parent reply other threads:[~2016-03-15 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 6:45 [PATCH v2 0/2] Irq/Mbigen: fix the IO remap problem in mbigen driver MaJun
2016-03-14 6:45 ` [PATCH v2 1/2] Irq/mbigen:Change the mbigen node definition in dt binding file MaJun
2016-03-14 7:49 ` Thomas Gleixner
2016-03-15 7:35 ` majun (F) [this message]
2016-03-14 6:45 ` [PATCH v2 2/2] Irq/mbigen:Change the mbigen driver based on the new mbigen node definition MaJun
2016-03-14 7:44 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7BB53.3060705@huawei.com \
--to=majun258@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox