From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Tue, 15 Mar 2016 11:10:20 +0100 Subject: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions In-Reply-To: <1456778924-20730-9-git-send-email-paul.gortmaker@windriver.com> References: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> <1456778924-20730-9-git-send-email-paul.gortmaker@windriver.com> Message-ID: <56E7DF8C.4030005@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/29/2016 09:48 PM, Paul Gortmaker wrote: > Fixups here tend to be more all over the map vs. some of the other > repeated/systematic ones we've seen elsewhere. > > We remove module.h from code that isn't doing anything modular at > all; if they have __init sections, then replace it with init.h > > A couple drivers have module_exit() code that is essentially orphaned, > and so we remove that. > > There are no module_init replacements, so we have no concerns wrt. > initcall ordering changes as per some of the other cleanups. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Tomasz Figa > Cc: Thomas Abraham > Cc: Linus Walleij > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-samsung-soc at vger.kernel.org > Cc: linux-gpio at vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 1 - > drivers/pinctrl/samsung/pinctrl-exynos5440.c | 15 +++------------ > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 2 +- > drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 2 +- > drivers/pinctrl/samsung/pinctrl-samsung.c | 12 +----------- > 5 files changed, 6 insertions(+), 26 deletions(-) Acked-by: Sylwester Nawrocki -- Thanks, Sylwester