[PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts

[PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts

[Hans de Goede]

u-boot uses the kernel as the canonical source for its sunxi dts files
and u-boot needs these.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 arch/arm/boot/dts/sun6i-a31s-primo81.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts
index 68b479b..379746a 100644
--- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts
+++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts
@@ -53,6 +53,14 @@
 / {
 	model = "MSI Primo81 tablet";
 	compatible = "msi,primo81", "allwinner,sun6i-a31s";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &cpu0 {
-- 
2.7.2

[PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts

[Chen-Yu Tsai]

On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> u-boot uses the kernel as the canonical source for its sunxi dts files
> and u-boot needs these.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

[PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts

[Maxime Ripard]

On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
> On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > u-boot uses the kernel as the canonical source for its sunxi dts files
> > and u-boot needs these.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Queued, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160318/3e95778f/attachment-0001.sig>

[linux-sunxi] Re: [PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts

[Hans de Goede]

Hi,

On 18-03-16 18:48, Maxime Ripard wrote:
> On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
>> On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>> u-boot uses the kernel as the canonical source for its sunxi dts files
>>> and u-boot needs these.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> Queued, thanks!

I just got an of-list mail from Karsten Merker that you nacked the addition
if this during the initial submission, because there are no accessible uart
test pads on this tablet.

In that case the proper fix would be to change the u-boot defconfig to have:

# CONFIG_REQUIRE_SERIAL_CONSOLE is not set

Which will stop u-boot from panicking (with nowhere to print the panic msg)
when it has no stdout-path.

Can you unqueue this one until we've figured out what the best fix is ?

Thanks & Regards,

Hans

[linux-sunxi] Re: [PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts

[Maxime Ripard]

On Sat, Mar 19, 2016 at 10:13:47AM +0100, Hans de Goede wrote:
> Hi,
> 
> On 18-03-16 18:48, Maxime Ripard wrote:
> >On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
> >>On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> >>>u-boot uses the kernel as the canonical source for its sunxi dts files
> >>>and u-boot needs these.
> >>>
> >>>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>
> >>Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
> >Queued, thanks!
> 
> I just got an of-list mail from Karsten Merker that you nacked the addition
> if this during the initial submission, because there are no accessible uart
> test pads on this tablet.
> 
> In that case the proper fix would be to change the u-boot defconfig to have:
> 
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> 
> Which will stop u-boot from panicking (with nowhere to print the panic msg)
> when it has no stdout-path.
> 
> Can you unqueue this one until we've figured out what the best fix is ?

Done, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160321/1933a8a8/attachment.sig>