From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] serial: amba-pl011: complete support to ZTE uart
Date: Mon, 21 Mar 2016 21:06:04 -0500 [thread overview]
Message-ID: <56F0A88C.9050209@codeaurora.org> (raw)
In-Reply-To: <CABymUCOX5zws9QfXp5Wud2JBAYJZH4rxPRVVgbk7tRvbUUHChA@mail.gmail.com>
Jun Nie wrote:
> That's a fair comment. I suppose all platform need to enable clock for
> the device. For device tree case, we need these code for clock
> enabling.
But why do you need to enable the clock? The pl011 driver works fine
for every platform without your patch. If the ZTE platform needs to
call clk_get() in order to work, than that is something different about
your platform.
> For ACPI case, it may be handled automatically. If you agree
> my opinion, I will move these lines to patch 1. Please correct me if I
> am wrong.
I think you need to create a separate patch that adds that call, and
make sure it's tested by other platforms before it gets accepted.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2016-03-22 2:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 1:51 [PATCH 1/2] serial: amba-pl011: make platform driver generic Jun Nie
2016-03-14 1:51 ` [PATCH 2/2] serial: amba-pl011: complete support to ZTE uart Jun Nie
2016-03-21 20:39 ` Timur Tabi
2016-03-22 1:16 ` Jun Nie
2016-03-22 1:55 ` Timur Tabi
2016-03-22 2:01 ` Jun Nie
2016-03-22 2:06 ` Timur Tabi [this message]
2016-03-22 2:17 ` Jun Nie
2016-03-22 8:20 ` G Gregory
2016-03-22 8:44 ` Jun Nie
2016-03-22 8:51 ` G Gregory
2016-03-21 7:33 ` [PATCH 1/2] serial: amba-pl011: make platform driver generic Jun Nie
2016-03-21 19:47 ` Timur Tabi
2016-03-22 1:25 ` Jun Nie
2016-03-22 1:56 ` Timur Tabi
2016-03-22 12:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F0A88C.9050209@codeaurora.org \
--to=timur@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).