From: sr@denx.de (Stefan Roese)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] spi: orion.c: Add direct access mode
Date: Wed, 23 Mar 2016 14:10:57 +0100 [thread overview]
Message-ID: <56F295E1.4030505@denx.de> (raw)
In-Reply-To: <20160323125448.GM2566@sirena.org.uk>
Hi Mark,
On 23.03.2016 13:54, Mark Brown wrote:
> On Wed, Mar 23, 2016 at 12:59:40PM +0100, Stefan Roese wrote:
>> On 23.03.2016 12:33, Mark Brown wrote:
>
>>> No, there's two separate things here. The big problem with what you
>>> originally sent was that you were defining a window per SPI device but
>>> this is a part of the SPI controller so having to change windows per
>>> device is just going to make the code more complex.
>
>> I'm sorry, but this sentence is not totally clear to me: Do you mean
>> that the "more complex" code in v2 with the MBus window reconfiguration
>> is not good? Or do you mean that in the RFC version, the switching
>> between the SPI devices was too complex?
>
> I haven't looked at your new code at all. What I'm saying is that
> specifying a per-device MBus window seems like pointless complexity.
I don't necessarily share this opinions. Code-wise, its less complex
that re-configuring (removing the old and creating the new) the MBus
window. But I have no strong feeling here. Whatever is decided that
should be used, I can go with.
Thomas, Arnd (or anyone else?), do you have any comments or preferences
which way to go here?
Thanks,
Stefan
next prev parent reply other threads:[~2016-03-23 13:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 16:24 [PATCH v2] spi: orion.c: Add direct access mode Stefan Roese
2016-03-22 16:35 ` Thomas Petazzoni
2016-03-22 16:44 ` Stefan Roese
2016-03-23 11:33 ` Mark Brown
2016-03-23 11:59 ` Stefan Roese
2016-03-23 12:54 ` Mark Brown
2016-03-23 13:10 ` Stefan Roese [this message]
2016-03-23 13:26 ` Andrew Lunn
2016-03-23 13:36 ` Mark Brown
2016-03-23 13:56 ` Andrew Lunn
2016-03-23 19:51 ` Arnd Bergmann
2016-03-24 7:22 ` Stefan Roese
2016-03-24 12:42 ` Arnd Bergmann
2016-03-24 16:15 ` Stefan Roese
2016-03-24 16:42 ` Arnd Bergmann
2016-03-24 17:30 ` Stefan Roese
2016-03-24 16:48 ` Arnd Bergmann
2016-03-24 17:51 ` Stefan Roese
2016-03-24 20:07 ` Arnd Bergmann
2016-03-25 10:32 ` Mark Brown
2016-03-25 15:11 ` Arnd Bergmann
2016-03-25 15:50 ` Mark Brown
2016-03-25 20:58 ` Arnd Bergmann
2016-03-25 22:39 ` Mark Brown
2016-03-29 12:39 ` Arnd Bergmann
2016-03-29 16:47 ` Mark Brown
2016-03-29 19:49 ` Arnd Bergmann
2016-03-29 19:52 ` Mark Brown
2016-03-29 20:04 ` Arnd Bergmann
2016-03-29 21:00 ` Mark Brown
2016-03-29 21:08 ` Arnd Bergmann
2016-03-29 21:28 ` Mark Brown
2016-03-29 22:04 ` Arnd Bergmann
2016-04-05 7:11 ` Stefan Roese
2016-04-05 13:15 ` Andrew Lunn
2016-04-05 13:20 ` Stefan Roese
2016-04-05 13:31 ` Andrew Lunn
2016-03-23 13:27 ` Mark Brown
2016-03-23 17:25 ` Stefan Roese
2016-03-23 18:29 ` Mark Brown
2016-03-23 18:39 ` Andrew Lunn
2016-03-24 5:45 ` Stefan Roese
2016-03-24 11:23 ` Mark Brown
2016-03-24 12:05 ` Stefan Roese
2016-03-22 17:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F295E1.4030505@denx.de \
--to=sr@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).