From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A478BC433F5 for ; Sat, 9 Apr 2022 00:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pdyBgbxHaKfsevfupWdJzMSRPYicaGqu1kivGkm9hg8=; b=tnKH3vnBZyN92t PeOjKJJIjQinwcoZMVO7pmmpcEyEi08hiwH2gfZeVLg/UlAggAlx0ez5kT1s+SuH5pJPSBP0KPMG8 pz8Hr6kLpu2I9jFF8Kjb2134KXwByZJsW+Y1MAAzULHpCsDgS9Q3x9bMny83VKuUsz3hBVz5/klC0 FFhmLGQtaErSGKuOwSt0nOB9FOdZTAXg0YVvxTIGgpxSfo+xYp9VSGSGWDxwWU44jStpwo0PhX9Wr GPAbr/cjV16ENjrp1FKNGwAJhM4aBl8gTD0EGorTMMzpUiNQ4ioUk7ZYadVEa1sfHGNFbyVUtowxJ PhjBflMVCCFoXM+9ixZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncyWf-001Wih-MD; Sat, 09 Apr 2022 00:00:25 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncyWc-001WiF-Mk for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 00:00:24 +0000 Received: by mail-wr1-x42c.google.com with SMTP id k23so15045753wrd.8 for ; Fri, 08 Apr 2022 17:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=M4fK1yo1NBIHG/5W6ZdoT+jscsUpt52urbAtX6EHweY=; b=Kbnf+OTmmmZ25Py7KZVEogMix9TXNLbqSs+Rby4Mck4nWKvGBvMG0Yu2oTCcjsopxe tac9vGLoQEqTba+57ySJl6CUS1A6BZRfBgzMYRR8hAbHS4wtx3oQCU0T6hEeF8h3Wljb p+UQLEGEkM6V1/rISJRGHb/h1YLXES7qXMHhPMOgiTRwGCT6g3mjF7XMWDXnqmX1KcCf 5t92VacE8vcq5J0j4lKxfq/44xUYXoNAVfxhlKmHVeFvv/MrkmHedjUiuMd7R6ykF5Go jYmTt7ztJv9nQIMfoTzEGMD+MIMTr7RyTmna9GZkjOGr866lASWUreb/L/vHg0ygsbM9 xMWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=M4fK1yo1NBIHG/5W6ZdoT+jscsUpt52urbAtX6EHweY=; b=ixFfPtq89IV35HjjbuemHYcg9p1SIKLhxzR42ZrEbsM8sACfNRLuzt32nVLvz22IVf cK/EcOToFu+ybMuxzbpaNmfAoPUKg78M2duqya92Wnjcf+n5mT6cGzzibUwoW/1bXHlD O+v+H1wBDfIcvwhFGSOeqHhtb0UDtU0W2hsJy6gSbBuXmUtgTq/6qo+InhLGwJUsRCh+ AkqVWasZw9ZrkocR5JaWOpydNuAjiBmwgNGpO8RYNlaFr5Cp9mDU/5/QbtFmkRY1VMFG eNq/sOjvUk058OpmsTOk4bd/574Ycd/RIeks6Vb+k7C7jXUYEbzVTCZmMUqDEYy8+on5 ni0w== X-Gm-Message-State: AOAM532c+VHwVLjNEJrTu5RpRp78QLS5NhVaRasQRAVKDUtBtvFVBJTX Mqa1GkbGn0bAc+92Lhd0y5U= X-Google-Smtp-Source: ABdhPJwsgzMxfu8oKABBvDjW9kco9sUI3QmbrtC5b9hgDi2efhG+oHaYpnT8EByLRhIHH6Va2p0drA== X-Received: by 2002:a5d:6989:0:b0:206:1517:9b66 with SMTP id g9-20020a5d6989000000b0020615179b66mr16236897wru.583.1649462421298; Fri, 08 Apr 2022 17:00:21 -0700 (PDT) Received: from smtpclient.apple ([185.238.38.242]) by smtp.gmail.com with ESMTPSA id w7-20020a1cf607000000b00389a5390180sm11277078wmc.25.2022.04.08.17.00.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Apr 2022 17:00:20 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH net-next 03/15] net: dsa: mv88e6xxx: Replace usage of found with dedicated iterator From: Jakob Koschel In-Reply-To: <20220408235051.2a4hh7p3lee3a3xv@skbuf> Date: Sat, 9 Apr 2022 02:00:18 +0200 Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Florian Fainelli , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Edward Cree , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Casper Andersson , Bjarni Jonasson , Colin Ian King , Michael Walle , Christophe JAILLET , Arnd Bergmann , Eric Dumazet , Di Zhu , Xu Wang , Netdev , LKML , Linux ARM , linuxppc-dev , Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Message-Id: <56F3A9DE-C80A-4932-AFEA-BB82251C1199@gmail.com> References: <20220407102900.3086255-1-jakobkoschel@gmail.com> <20220407102900.3086255-4-jakobkoschel@gmail.com> <20220408123101.p33jpynhqo67hebe@skbuf> <20220408235051.2a4hh7p3lee3a3xv@skbuf> To: Vladimir Oltean X-Mailer: Apple Mail (2.3696.80.82.1.1) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_170022_810506_64B4F844 X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 9. Apr 2022, at 01:50, Vladimir Oltean wrote: > > On Sat, Apr 09, 2022 at 01:44:00AM +0200, Jakob Koschel wrote: >>> Let's try to not make convoluted code worse. Do the following 2 patches >>> achieve what you are looking for? Originally I had a single patch (what >>> is now 2/2) but I figured it would be cleaner to break out the unrelated >>> change into what is now 1/2. >> >> I do agree with not making convoluted code worse, but I was reluctant with >> e.g. introducing new functions for this because others essentially >> have the opposite opinion on this. >> >> I however like solving it that way, it makes it a lot cleaner. > > Yeah, I think 'just adapt to the context and style and intentions of the > code you're changing and don't try to push a robotic one-size-fits-all > solution' is sensible enough for an initial guiding principle. > >>> If you want I can submit these changes separately. >> >> Sure if you want to submit them separately, go ahead. Otherwise I can >> integrate it into a v2, whatever you prefer essentially. > > If you're moving quickly feel free to pick them up. I have lots of other > things on my backlog so it won't be until late next week until I even > consider submitting these. I'm planning to send a v2 earlier than that, so I'll just integrate it there. Thanks, Jakob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel