linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kernel@tekno-soft.it (Roberto Fichera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date: Tue, 29 Mar 2016 18:13:53 +0200	[thread overview]
Message-ID: <56FAA9C1.5060107@tekno-soft.it> (raw)
In-Reply-To: <CAJ+vNU3kBk+J-hU1OWPOS6kbFq+J0zM9QpfVy4x1VXL3hgrMTg@mail.gmail.com>

On 03/29/2016 05:10 PM, Tim Harvey wrote:
> Arnd,
>
> Right, on the IMX the MSI interrupt is GIC-120 which is also the
> legacy INTD and I do see that if I happen to put a radio in a slot
> where due to swizzling its pin1 becomes INTD (GIC-120) the interrupt
> does fire and the device works. Any other slot using GIC-123 (INTA),
> GIC-122 (INTB), or GIC-121 (INTC) never fires so its very possible
> that something in the designware core is masking out the legacy irqs.
> I would also think this was something IMX specific, but I really don't
> see any codepaths in pci-imx6.c that would cause that: a driver
> requesting a legacy PCI would get a GIC interrupt which is handled by
> the IMX6 gpc interrupt controller.
>
> Any dra7xxx, exynos, spear13xx, keystone, layerscape, hisi, qcom SoC
> users of designware PCIe core out there that can verify PCI MSI and
> legacy are both working at the same time?
>
> Lucas is the expert here and I believe he has the documentation for
> the designware core that Freescale doens't provide with the IMX6
> documentation so hopefully he can provide some insight. He's the one
> that has authored all the MSI support and has been using it.
>
> I typically advise our users to 'not' enable MSI because
> architecturally you can spread 4 distinct legacy irq's across CPU's
> better than a single shared irq.

Don't know if I'm facing similar problem, however devices connected in miniPCI slot behind
a PCIe-to-PCI bridge (MSI is disabled) using INTA all is working ok, including shared IRQ.
In case of INTB will not work, and the GIC irq quite often get stuck.

  parent reply	other threads:[~2016-03-29 16:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 13:32 [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Krzysztof Hałasa
2016-03-27 14:44 ` Fabio Estevam
2016-03-28  0:26   ` Fabio Estevam
2016-03-28 19:59     ` Tim Harvey
2016-03-28 20:13       ` Fabio Estevam
2016-03-28 20:42         ` Tim Harvey
2016-03-28 21:30           ` Fabio Estevam
2016-03-28 22:06             ` Tim Harvey
2016-03-28 22:13               ` Fabio Estevam
2016-03-29  5:40                 ` Krzysztof Hałasa
2016-03-29  5:43                   ` Krzysztof Hałasa
2016-03-29  5:29               ` Krzysztof Hałasa
2016-03-29  8:55               ` Lucas Stach
2016-03-29 10:39                 ` Krzysztof Hałasa
2016-03-29 10:55                   ` Lucas Stach
2016-03-29 13:12                     ` Arnd Bergmann
2016-03-29 13:32                     ` Tim Harvey
2016-03-29 13:52                       ` Arnd Bergmann
2016-03-29 14:29                         ` Tim Harvey
2016-03-29 14:50                           ` Arnd Bergmann
2016-03-29 15:10                             ` Tim Harvey
2016-03-29 15:24                               ` Arnd Bergmann
2016-03-29 17:38                                 ` Tim Harvey
2016-03-29 19:39                                   ` Arnd Bergmann
2016-03-29 17:56                                 ` Marc Zyngier
2016-03-29 16:13                               ` Roberto Fichera [this message]
2016-03-29 16:40                                 ` Tim Harvey
2016-03-29 16:44                                   ` Roberto Fichera
2016-03-29 17:31                                     ` Tim Harvey
2016-03-30  8:00                                       ` Roberto Fichera
2016-03-30 10:10                                         ` Arnd Bergmann
2016-03-30 12:50                                           ` Roberto Fichera
2016-03-30 13:38                                             ` Tim Harvey
2016-03-30 15:20                                               ` Roberto Fichera
2016-03-30  8:10                     ` Krzysztof Hałasa
2016-03-31 16:19                       ` Tim Harvey
2016-04-04 10:37                         ` Krzysztof Hałasa
2016-03-29 14:14                 ` Fabio Estevam
2016-03-29  5:21           ` Krzysztof Hałasa
2016-03-30 12:06 ` Petr Štetiar
2016-03-30 12:45   ` Fabio Estevam
2016-03-30 14:38   ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FAA9C1.5060107@tekno-soft.it \
    --to=kernel@tekno-soft.it \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).