From: neil.armstrong@linaro.org
To: Chen Ni <nichen@iscas.ac.cn>,
broonie@kernel.org, khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, yixun.lan@amlogic.com,
sunny.luo@amlogic.com
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: meson-spicc: convert comma to semicolon
Date: Tue, 16 Jul 2024 11:31:12 +0200 [thread overview]
Message-ID: <56a90ea2-6bba-42ef-b615-61f8c797e09c@linaro.org> (raw)
In-Reply-To: <20240716091151.1434450-1-nichen@iscas.ac.cn>
On 16/07/2024 11:11, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Fixes: 3e0cf4d3fc29 ("spi: meson-spicc: add a linear clock divider support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/spi/spi-meson-spicc.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index 8838a98b04c2..1d05590a7434 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -655,8 +655,8 @@ static int meson_spicc_pow2_clk_init(struct meson_spicc_device *spicc)
> }
> init.num_parents = 1;
>
> - pow2_fixed_div->mult = 1,
> - pow2_fixed_div->div = 4,
> + pow2_fixed_div->mult = 1;
> + pow2_fixed_div->div = 4;
> pow2_fixed_div->hw.init = &init;
>
> clk = devm_clk_register(dev, &pow2_fixed_div->hw);
> @@ -674,9 +674,9 @@ static int meson_spicc_pow2_clk_init(struct meson_spicc_device *spicc)
> parent_data[0].hw = &pow2_fixed_div->hw;
> init.num_parents = 1;
>
> - spicc->pow2_div.shift = 16,
> - spicc->pow2_div.width = 3,
> - spicc->pow2_div.flags = CLK_DIVIDER_POWER_OF_TWO,
> + spicc->pow2_div.shift = 16;
> + spicc->pow2_div.width = 3;
> + spicc->pow2_div.flags = CLK_DIVIDER_POWER_OF_TWO;
> spicc->pow2_div.reg = spicc->base + SPICC_CONREG;
> spicc->pow2_div.hw.init = &init;
>
> @@ -721,8 +721,8 @@ static int meson_spicc_enh_clk_init(struct meson_spicc_device *spicc)
> }
> init.num_parents = 1;
>
> - enh_fixed_div->mult = 1,
> - enh_fixed_div->div = 2,
> + enh_fixed_div->mult = 1;
> + enh_fixed_div->div = 2;
> enh_fixed_div->hw.init = &init;
>
> clk = devm_clk_register(dev, &enh_fixed_div->hw);
> @@ -740,8 +740,8 @@ static int meson_spicc_enh_clk_init(struct meson_spicc_device *spicc)
> parent_data[0].hw = &enh_fixed_div->hw;
> init.num_parents = 1;
>
> - enh_div->shift = 16,
> - enh_div->width = 8,
> + enh_div->shift = 16;
> + enh_div->width = 8;
> enh_div->reg = spicc->base + SPICC_ENH_CTL0;
> enh_div->hw.init = &init;
>
> @@ -761,8 +761,8 @@ static int meson_spicc_enh_clk_init(struct meson_spicc_device *spicc)
> init.num_parents = 2;
> init.flags = CLK_SET_RATE_PARENT;
>
> - mux->mask = 0x1,
> - mux->shift = 24,
> + mux->mask = 0x1;
> + mux->shift = 24;
> mux->reg = spicc->base + SPICC_ENH_CTL0;
> mux->hw.init = &init;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2024-07-16 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 9:11 [PATCH] spi: meson-spicc: convert comma to semicolon Chen Ni
2024-07-16 9:31 ` neil.armstrong [this message]
2024-07-29 15:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56a90ea2-6bba-42ef-b615-61f8c797e09c@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nichen@iscas.ac.cn \
--cc=sunny.luo@amlogic.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).