From: daniel.thompson@linaro.org (Daniel Thompson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwrng: stm32 - fix build warning
Date: Tue, 24 May 2016 11:09:42 +0100 [thread overview]
Message-ID: <56bb8ec4-fe7e-ec09-adc3-ec7eea2d7ddd@linaro.org> (raw)
In-Reply-To: <CALszF6BPPA=tezMLhmdC4YFwmH1tGhDxCNDZNwGp1cTDWP7Fmg@mail.gmail.com>
On 24/05/16 09:50, Maxime Coquelin wrote:
> diff --git a/drivers/char/hw_random/stm32-rng.c
> b/drivers/char/hw_random/stm32-rng.c
> index 92a810648bd0..2a0fc90e4dc3 100644
> --- a/drivers/char/hw_random/stm32-rng.c
> +++ b/drivers/char/hw_random/stm32-rng.c
> @@ -68,6 +68,10 @@ static int stm32_rng_read(struct hwrng *rng, void
> *data, size_t max, bool wait)
> } while (!sr && --timeout);
> }
>
> + if (WARN_ONCE(sr & (RNG_SR_SEIS | RNG_SR_CEIS),
> + "bad RNG status - %x\n", sr))
> + writel_relaxed(0, priv->base + RNG_SR);
> +
> /* If error detected or data not ready... */
> if (sr != RNG_SR_DRDY)
> break;
Minor quibble but I might prefer that the error handling/recovery
actually be put on the error path itself (included in the if (sr !=
RNG_SR_DRDY) ).
Daniel.
next prev parent reply other threads:[~2016-05-24 10:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 12:44 [PATCH] hwrng: stm32 - fix build warning Sudip Mukherjee
2016-05-23 20:35 ` Arnd Bergmann
2016-05-24 7:59 ` Maxime Coquelin
2016-05-24 8:32 ` Arnd Bergmann
2016-05-24 8:50 ` Maxime Coquelin
2016-05-24 8:58 ` Arnd Bergmann
2016-05-24 9:20 ` Maxime Coquelin
2016-05-25 2:00 ` Sudip Mukherjee
2016-05-24 10:09 ` Daniel Thompson [this message]
2016-05-24 10:57 ` Maxime Coquelin
2016-05-25 2:05 ` Sudip Mukherjee
2016-05-25 10:06 ` Arnd Bergmann
2016-05-27 9:00 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56bb8ec4-fe7e-ec09-adc3-ec7eea2d7ddd@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).