From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] iommu/dma: Restore scatterlist offsets correctly
Date: Tue, 5 Apr 2016 14:11:38 +0100 [thread overview]
Message-ID: <5703B98A.6010200@arm.com> (raw)
In-Reply-To: <20160405125926.GI17838@8bytes.org>
On 05/04/16 13:59, Joerg Roedel wrote:
> On Thu, Mar 10, 2016 at 07:28:12PM +0000, Robin Murphy wrote:
>> With the change to stashing just the IOVA-page-aligned remainder of the
>> CPU-page offset rather than the whole thing, the failure path in
>> __invalidate_sg() also needs tweaking to account for that in the case of
>> differing page sizes where the two offsets may not be equivalent.
>> Similarly in __finalise_sg(), lest the architecture-specific wrappers
>> later get the wrong address for cache maintenance on sync or unmap.
>>
>> Fixes: 164afb1d85b8 ("iommu/dma: Use correct offset in map_sg")
>> Reported-by: Magnus Damm <damm+renesas@opensource.se>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>
> Cc: stable at ver.kernel.org # v4.4+ ?
Good point - the kind of people using 64k pages are also likely to be
the ones sticking to stable kernels. Are you able to handle that, or
would you like me to resend?
Thanks,
Robin.
>
>
> Joerg
>
next prev parent reply other threads:[~2016-04-05 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 19:28 [PATCH 1/2] iommu/dma: Restore scatterlist offsets correctly Robin Murphy
2016-03-10 19:28 ` [PATCH 2/2] iommu/dma: Implement scatterlist segment merging Robin Murphy
2016-04-05 11:16 ` [PATCH 1/2] iommu/dma: Restore scatterlist offsets correctly Robin Murphy
2016-04-05 12:59 ` Joerg Roedel
2016-04-05 13:11 ` Robin Murphy [this message]
2016-04-05 13:33 ` Joerg Roedel
2016-04-05 14:06 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703B98A.6010200@arm.com \
--to=robin.murphy@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).