From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pci, acpi: free IO resource during shutdown
Date: Fri, 8 Apr 2016 13:46:23 -0400 [thread overview]
Message-ID: <5707EE6F.2050509@codeaurora.org> (raw)
In-Reply-To: <570754D7.3010009@semihalf.com>
Hi Tomasz,
On 4/8/2016 2:51 AM, Tomasz Nowicki wrote:
> Hi Sinan,
>
> On 08.04.2016 05:40, Sinan Kaya wrote:
>> Hi Tomasz,
>>
>> On 4/7/2016 5:41 PM, Bjorn Helgaas wrote:
>>>>> You say this is undoing the effect of pci_remap_iospace(), but that's
>>>>>>> only called by native drivers and the generic (OF) driver, not by
>>>>>>> pci_root.c.
>>>>>
>>>>> See the ACPI root bridge driver above.
>>> If this is a fix to patches that haven't been merged yet, we need to
>>> squash the fix into the patches.
>>>
>>
>> Can you merge these to two patches to your series for the next post?
>>
>> I need to remove weak on the first patch per direction from Bjorn and
>> fix the function comments. You could as well do this while you are merging.
>>
>> Let me know what your preference is.
>>
>
> Please do necessary fixes for your patches and send me the repo reference link. I will merge these to my patch set. Thanks!
>
> Tomasz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
I posted the updated patch here. Changes are:
- I squashed these two patches together per Bjorn's request.
- Removed the weak declarations from both remap and unmap calls.
- Fixed the doxygen document to match the actual parameters.
https://us.codeaurora.org/cgit/quic/server/kernel/commit/?h=okaya/pciunmapv2&id=6120a5f0c5e6d757f18a076917fa202e2c9823d0
Sinan
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-08 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 22:21 [PATCH 1/2] pci: add pci_unmap_iospace function for PCI_IOBASE Sinan Kaya
2016-03-07 22:21 ` [PATCH 2/2] pci, acpi: free IO resource during shutdown Sinan Kaya
2016-04-07 16:06 ` Bjorn Helgaas
2016-04-07 17:45 ` Sinan Kaya
2016-04-07 21:41 ` Bjorn Helgaas
2016-04-08 3:40 ` Sinan Kaya
2016-04-08 6:51 ` Tomasz Nowicki
2016-04-08 17:46 ` Sinan Kaya [this message]
2016-04-09 8:44 ` Tomasz Nowicki
2016-03-16 23:14 ` [PATCH 1/2] pci: add pci_unmap_iospace function for PCI_IOBASE Sinan Kaya
2016-04-07 16:00 ` Bjorn Helgaas
2016-04-07 17:49 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5707EE6F.2050509@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).