From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config
Date: Mon, 18 Apr 2016 17:54:09 +0800 [thread overview]
Message-ID: <5714AEC1.7050409@rock-chips.com> (raw)
In-Reply-To: <20160418102538.0ed730ca.john@metanate.com>
On 2016?04?18? 17:25, John Keeping wrote:
>> >We need to take care of the vop status when use
>> >rockchip_drm_crtc_mode_config, if vop is disabled,
>> >the function would failed, that is terrible.
>> >
>> >Save connector type and output mode on drm_display_mode->private_flags
>> >at encoder mode_fixup, then we can configure the type and mode safely
>> >on crtc mode_set.
> Since Rockchip is atomic, shouldn't this be using atomic_check hooks and
> a subclassed crtc_state structure?
>
Right, Good idea.
Thanks.
--
?ark Yao
next prev parent reply other threads:[~2016-04-18 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 3:03 [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config Mark Yao
2016-04-18 9:25 ` John Keeping
2016-04-18 9:54 ` Mark yao [this message]
2016-04-19 2:43 ` Mark yao
2016-04-19 9:06 ` John Keeping
2016-04-20 2:20 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5714AEC1.7050409@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).