From: kernel@martin.sperl.org (Martin Sperl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname
Date: Wed, 20 Apr 2016 13:06:15 +0200 [thread overview]
Message-ID: <571762A7.7000005@martin.sperl.org> (raw)
In-Reply-To: <CAMuHMdW2Jw5=f9ojNSM0d1cGvPc6_QxwH4rcQdWBQTP89zyj4Q@mail.gmail.com>
On 20.04.2016 08:51, Geert Uytterhoeven wrote:
> On Mon, Apr 11, 2016 at 3:29 PM, <kernel@martin.sperl.org> wrote:
>> From: Martin Sperl <kernel@martin.sperl.org>
>>
>> Use platform_get_irq_byname to allow for correct mapping of
>> interrupts to dma channels.
>>
>> The currently implemented device tree is unfortunately
>> implemented with the wrong assumption, that each dma-channel
>> has its own dma channel, but dma-irq 11 is handling
>> dma-channel 11-14 and dma-irq 12 is actually a "catch all"
>> interrupt.
>>
>> So here we use the byname variant and require that interrupts
>> are explicitly named via the interrupts-name property in the
>
> interrupt-names
Vinod has just merged this patch - do you want me to submit another
to correct those?
> You're not explicitly looking for "dma-shared-all" for that?
> You might as well just declare a single unnamed interrupt in the bindings.
dma-shared-all is unfortunately an interrupt-line that triggers
for interrupt-channels 0-15 and that includes the dma channels
that are owned by the firmware.
It is there mostly to document the interrupt-line (which is there in the
existing device tree files - it is not used.
Martin
next prev parent reply other threads:[~2016-04-20 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 13:29 [PATCH V2 0/3] dmaengine: bcm2835: support dma channel 11 to 14 kernel at martin.sperl.org
2016-04-11 13:29 ` [PATCH V2 1/3] dt/bindings: bcm2835: add interrupt-names property kernel at martin.sperl.org
2016-04-11 13:29 ` [PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname kernel at martin.sperl.org
2016-04-20 6:51 ` Geert Uytterhoeven
2016-04-20 11:06 ` Martin Sperl [this message]
2016-04-20 11:12 ` Geert Uytterhoeven
2016-04-20 13:11 ` Vinod Koul
2016-04-11 13:29 ` [PATCH V2 3/3] ARM: bcm2835: add interrupt-names and apply correct mapping kernel at martin.sperl.org
2016-04-19 15:33 ` [PATCH V2 0/3] dmaengine: bcm2835: support dma channel 11 to 14 Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571762A7.7000005@martin.sperl.org \
--to=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).