linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx28-m28: Fix unit-address for partitions
Date: Wed, 27 Apr 2016 16:45:19 +0200	[thread overview]
Message-ID: <5720D07F.2040309@denx.de> (raw)
In-Reply-To: <1461765754-19020-1-git-send-email-fabio.estevam@nxp.com>

On 04/27/2016 04:02 PM, Fabio Estevam wrote:
> According to ePAPR v1.1: "The unit-address must match the first address
> specified in the reg property of the node"
> 
> So do as recommended.

Looks good, but if I may, I would suggest something more drastic.
Would you instead remove the whole partitioning from the M28 DT?
We always pass mtdparts from command line, so having some sort of
default partitioning is quite pointless.

Thanks for spotting this though, it's a good reminder to review
older boards.

> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/boot/dts/imx28-m28.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-m28.dtsi b/arch/arm/boot/dts/imx28-m28.dtsi
> index 759cc56..6270701 100644
> --- a/arch/arm/boot/dts/imx28-m28.dtsi
> +++ b/arch/arm/boot/dts/imx28-m28.dtsi
> @@ -34,22 +34,22 @@
>  					read-only;
>  				};
>  
> -				partition at 1 {
> +				partition at 300000 {
>  					label = "environment";
>  					reg = <0x00300000 0x00080000>;
>  				};
>  
> -				partition at 2 {
> +				partition at 380000 {
>  					label = "redundant-environment";
>  					reg = <0x00380000 0x00080000>;
>  				};
>  
> -				partition at 3 {
> +				partition at 400000 {
>  					label = "kernel";
>  					reg = <0x00400000 0x00400000>;
>  				};
>  
> -				partition at 4 {
> +				partition at 800000 {
>  					label = "filesystem";
>  					reg = <0x00800000 0x0f800000>;
>  				};
> 


-- 
Best regards,
Marek Vasut

      reply	other threads:[~2016-04-27 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 14:02 [PATCH] ARM: dts: imx28-m28: Fix unit-address for partitions Fabio Estevam
2016-04-27 14:45 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5720D07F.2040309@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).