From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/7] vfio: platform: add capability to register a reset function
Date: Fri, 23 Oct 2015 15:07:37 +0200 [thread overview]
Message-ID: <5723752.hDK15zeNcm@wuerfel> (raw)
In-Reply-To: <1445603835-14506-3-git-send-email-eric.auger@linaro.org>
On Friday 23 October 2015 14:37:10 Eric Auger wrote:
> +
> +void vfio_platform_unregister_reset(const char *compat)
> +{
> + struct vfio_platform_reset_node *iter, *temp;
> +
> + mutex_lock(&driver_lock);
> + list_for_each_entry_safe(iter, temp, &reset_list, link) {
> + if (!strcmp(iter->compat, compat)) {
> + list_del(&iter->link);
> + break;
> + }
> + }
> +
> + mutex_unlock(&driver_lock);
> +}
> +EXPORT_SYMBOL_GPL(vfio_platform_unregister_reset);
>
This is slightly unsafe in case you ever get two drivers that register
with the same compat string. If we care about that, we could pass
and compare both the string and the function pointer, or the
vfio_platform_reset_node.
Arnd
next prev parent reply other threads:[~2015-10-23 13:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:37 [PATCH v3 0/7] VFIO platform reset module rework Eric Auger
2015-10-23 12:37 ` [PATCH v3 1/7] vfio: platform: introduce vfio-platform-base module Eric Auger
2015-10-23 13:04 ` Arnd Bergmann
2015-10-23 12:37 ` [PATCH v3 2/7] vfio: platform: add capability to register a reset function Eric Auger
2015-10-23 13:07 ` Arnd Bergmann [this message]
2015-10-23 14:15 ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro Eric Auger
2015-10-23 13:09 ` Arnd Bergmann
2015-10-23 14:10 ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 4/7] vfio: platform: reset: calxedaxgmac: add reset function registration Eric Auger
2015-10-23 13:09 ` Arnd Bergmann
2015-10-23 12:37 ` [PATCH v3 5/7] vfio: platform: add compat in vfio_platform_device Eric Auger
2015-10-23 12:37 ` [PATCH v3 6/7] vfio: platform: use list of registered reset function Eric Auger
2015-10-23 13:12 ` Arnd Bergmann
2015-10-23 14:11 ` Eric Auger
2015-10-23 14:23 ` Arnd Bergmann
2015-10-23 15:15 ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 7/7] vfio: platform: add dev_info on device reset Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5723752.hDK15zeNcm@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).