From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: Samsung: PWM: Allow to differentiate SoCs based on platform device name.
Date: Tue, 06 Sep 2011 13:35:58 +0200 [thread overview]
Message-ID: <5725201.5LdnvaEu1n@flatron> (raw)
In-Reply-To: <20110906110311.GM6619@n2100.arm.linux.org.uk>
On Tuesday 06 of September 2011 at 12:03:11, Russell King - ARM Linux wrote:
> On Tue, Sep 06, 2011 at 12:41:07PM +0200, Tomasz Figa wrote:
> > On Thursday 01 of September 2011 at 13:18:32, Tomasz Figa wrote:
> > > Well, now we have three alternatives:
> > > - to leave it as is (i.e. changing platform device names)
> > > - to use cpu_is_* (does it ever exist for S3C64xx or soc_is_s3c64xx is its equivalent?)
> > > - to use soc_is_*
> > >
> > > Waiting for more comments then.
> > >
> > Ping.
> >
> > Should I keep it as is or rather change it to use soc_is_s3c64xx instead?
>
> I don't know what question you're asking (the questions don't make sense
> in terms of the quoted context.)
>
> If you're asking whether you should use a cpu_ prefix instead of a soc_
> prefix for identifying s3c64xx, then consider the question.
>
> What is the CPU?
>
> What are S3C64xx / OMAP / PXA310 / SA-11x0 / AT91RM9200? CPU or SoC ?
> What are Cortex A8/A9 / Xscale / StrongARM / ARM920? CPU or SoC ?
Well, I believe that the context I quoted explains everything, but let me
explain that again:
The patch is about a driver being able to check to what SoC a device belongs,
but there are at least two ways to achieve that.
I can see many drivers using the way I used, i.e. distinct platform device names
for each SoC that has to be differentiated plus a generic one. However, I was
suggested that using cpu_is_*/soc_is_* might be a better approach, while at the
same time I received an opinion that the original method is the preferred one.
Best regards,
Tom
next prev parent reply other threads:[~2011-09-06 11:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 12:33 [PATCH 0/5] Add high resolution generic time support for S3C64xx Tomasz Figa
2011-08-31 12:34 ` [PATCH 1/5] ARM: Samsung: PWM: Allow to differentiate SoCs based on platform device name Tomasz Figa
2011-08-31 12:44 ` Mark Brown
2011-08-31 13:30 ` Tomasz Figa
2011-09-01 2:26 ` Kukjin Kim
2011-09-01 3:33 ` Kyungmin Park
2011-09-01 11:18 ` Tomasz Figa
2011-09-01 12:32 ` Mark Brown
2011-09-06 10:41 ` Tomasz Figa
2011-09-06 11:03 ` Russell King - ARM Linux
2011-09-06 11:35 ` Tomasz Figa [this message]
2011-09-06 12:04 ` Russell King - ARM Linux
2011-09-07 19:01 ` Mark Brown
2011-10-10 9:58 ` Kukjin Kim
2011-08-31 12:34 ` [PATCH 2/5] ARM: s3c64xx: Add generic high resolution time support using PWM timers Tomasz Figa
2011-10-10 9:57 ` Kukjin Kim
2011-10-11 13:32 ` Tomasz Figa
2011-10-13 14:22 ` Russell King - ARM Linux
2011-08-31 12:35 ` [PATCH 3/5] ARM: Samsung: pwm: Exclude timer 3 on S3C64xx if generic time is enabled Tomasz Figa
2011-08-31 12:35 ` [PATCH 4/5] ARM: s3c64xx: Move all machines to s3c64xx_timer Tomasz Figa
2011-08-31 12:36 ` [PATCH 5/5] ARM: s3c64xx: Add optional local sched_clock implementation Tomasz Figa
-- strict thread matches above, loose matches on Subject: below --
2011-08-27 23:32 [PATCH 1/5] ARM: Samsung: PWM: Allow to differentiate SoCs based on platform device name Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5725201.5LdnvaEu1n@flatron \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox