From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 06 May 2016 08:28:48 +0200 Subject: [RFC v2 13/13] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3 In-Reply-To: <9dff13ae-5863-2b45-0e6a-00b345a19019@osg.samsung.com> References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <1462451666-17945-14-git-send-email-k.kozlowski@samsung.com> <9dff13ae-5863-2b45-0e6a-00b345a19019@osg.samsung.com> Message-ID: <572C39A0.8030701@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/05/2016 10:16 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> On Odroid U3 (Exynos4412-based) board if USB was initialized by >> bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) >> and LAN (smsc95xx) after after successful probing were not visible in the >> system ("lsusb"). >> >> In such case the devices had to be fully reset before configuring. >> Reset by GPIO (called RESET_N pin) and by RESET field in STCD register >> in usb3503 HUB are not sufficient. Instead full reset has to be done by >> disabling and enabling regulator. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [snip] > >> >> + lan_pwrseq: pwrseq2 { >> + compatible = "mmc-pwrseq-simple"; > > It feels strange to have a "mmc-pwrseq-simple" compatible for a USB power > sequence provider. As I mentioned in the other patch, I think there should > either be a DT binding for the USB pwrseq-simple with a "usb-pwrseq-simple" > compatible that binds to the same pwrseq-simple driver or maybe having a > generic DT binding for any device with a new "pwrseq-simple" compatible. > > Patch looks good to me though, so after having a DT binding and changing > the compatible string: > > Reviewed-by: Javier Martinez Canillas Probably this will change after Rob's feedback. :) Best regards, Krzysztof