linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vladimir.murzin@arm.com (Vladimir Murzin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Support MPS2 UART controller
Date: Fri, 6 May 2016 15:43:24 +0100	[thread overview]
Message-ID: <572CAD8C.5000102@arm.com> (raw)
In-Reply-To: <CAP=VYLopd8erCP9J9cTyZ+YubafKjWi3bHQp-swmyfyn2eZ_Ww@mail.gmail.com>

On 06/05/16 15:31, Paul Gortmaker wrote:
> On Mon, Apr 25, 2016 at 4:47 AM, Vladimir Murzin
> <vladimir.murzin@arm.com> wrote:
>> Hi,
>>
>> These patches allow to use UART controller found on MPS2 platform.
> 
> Did you intend this driver to support being modular?  It has a bool Kconfig
> (not tristate) which makes the module_exit dead code.
> 
> If it will always be builtin (with console as primary use case) then you can
> see commit 89ebc27427695bfc1e769f1dd99bd243d332ac7a as a possible
> update suggestion.

Thanks for the pointer, Paul! I'll see how to update the driver and send
a patch after next merge window closed.

Cheers
Vladimir

> 
> P.
> --
> 
>>
>> Following [1], please, consider to merge them into tty/serial tree.
>>
>> [1] https://lkml.org/lkml/2016/4/23/190
>>
>> Thanks!
>>
>> Vladimir Murzin (3):
>>   dt-bindings: document the MPS2 UART bindings
>>   serial: mps2-uart: add MPS2 UART driver
>>   serial: mps2-uart: add support for early console
>>
>>  .../devicetree/bindings/serial/arm,mps2-uart.txt   |   19 +
>>  drivers/tty/serial/Kconfig                         |   13 +
>>  drivers/tty/serial/Makefile                        |    1 +
>>  drivers/tty/serial/mps2-uart.c                     |  625 ++++++++++++++++++++
>>  include/uapi/linux/serial_core.h                   |    3 +
>>  5 files changed, 661 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/serial/arm,mps2-uart.txt
>>  create mode 100644 drivers/tty/serial/mps2-uart.c
>>
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

      reply	other threads:[~2016-05-06 14:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25  8:47 [PATCH 0/3] Support MPS2 UART controller Vladimir Murzin
2016-04-25  8:47 ` [PATCH 1/3] dt-bindings: document the MPS2 UART bindings Vladimir Murzin
2016-04-25  8:47 ` [PATCH 2/3] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin
2016-04-25  8:47 ` [PATCH 3/3] serial: mps2-uart: add support for early console Vladimir Murzin
2016-05-06 14:31 ` [PATCH 0/3] Support MPS2 UART controller Paul Gortmaker
2016-05-06 14:43   ` Vladimir Murzin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572CAD8C.5000102@arm.com \
    --to=vladimir.murzin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).