From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C245C48BF6 for ; Mon, 26 Feb 2024 06:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=11Dh0tMqBb/Pm8AFV015kZOkzN3Yxphz0OdYcS+KdmQ=; b=nAhBut/yTIhKmP 9DF2+xZD5hy+J5GoZt799fOwTp/Y9ftidQxEMm8TpitRh6WG0ifoMxsuZPl3D2HrQG8x22GAF1gQo 6okcZ7JOHK2PzdL9jdVGN+72Zf2climG9456GWN45WevQwcc93B59qA2CqdtKzE/oF93DdLMj+vbF WKVTHArETlFSkPQXZzG/LIrK5FLZ0+KaVRGcFBZrrhKCLk5qiDer7jONObfGw1C2wEoyHyAiKCO+y sAmNfSmyswOGe82vSmgPqLrIWSE4ivoHz17Soa16jS7w/vLzMpJYOC1uMKpl+7bVqiODEwEh0/Gz+ kikPxzUiG2WKEJl8YXpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reUtT-0000000GiLW-1Y6J; Mon, 26 Feb 2024 06:55:19 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reUtM-0000000GiKr-4571 for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 06:55:16 +0000 Received: from [192.168.68.112] (ppp118-210-168-240.adl-adc-lon-bras34.tpg.internode.on.net [118.210.168.240]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id B956D20179; Mon, 26 Feb 2024 14:55:04 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1708930507; bh=fM/+3i+uo0h9vj6JNAMzhCNj28si11s6PI7s/m/RuUY=; h=Subject:From:To:Date:In-Reply-To:References; b=KgKbjAAs+ka/ghyfQ9+7i5uuod5smNXfmAGyDfK07wVFz+gn6AHadyfkmyIUVXSjq t6+ThglVkkhai65wquLw0Dh3jNItCyaydHI+BBft//thg4/YGLxeyg5C05ICZxmXQA XWivXnQUcZDAqXuyzk/bP22+zj8+P+ngKPVGw3i0ZrIzkQnYVymN/9nlPWlei3owVX 14T/R9kfrLEqZDm3dKpCFKqpptPL37FhZSoaLIWRPVBPDClo0HeoD6nac8GVXl0vM2 jiMf6cQCtzQOZSPYhyhPHuz5L15gp0XjU1XcLyJjNJuYdUxEjq3/KetNDw+5qe060I LeDSIoxj/uI8Q== Message-ID: <572d53516dee6db5af7089090056185abb4e78c7.camel@codeconstruct.com.au> Subject: Re: [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform From: Andrew Jeffery To: Supreeth Venkatesh , joel@jms.id.au, andrew@aj.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, robh+dt@kernel.org Date: Mon, 26 Feb 2024 17:25:03 +1030 In-Reply-To: <20240110033543.799919-1-supreeth.venkatesh@amd.com> References: <20240110033543.799919-1-supreeth.venkatesh@amd.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240225_225513_246306_A6C90A07 X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2024-01-09 at 21:35 -0600, Supreeth Venkatesh wrote: > This patch adds initial device tree and makefile updates for > AMD Onyx platform. > > AMD Onyx platform is an AMD customer reference board with an Aspeed > ast2600 BMC manufactured by AMD. > It describes I2c devices, Fans, Kcs devices, Uarts, Mac, LEDs, etc. > present on AMD Onyx platform. > > Signed-off-by: Supreeth Venkatesh > --- > arch/arm/boot/dts/aspeed/Makefile | 1 + > .../boot/dts/aspeed/aspeed-bmc-amd-onyx.dts | 98 +++++++++++++++++++ > 2 files changed, 99 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts > > diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile > index fb9cc95f1b60..2b27d377aae2 100644 > --- a/arch/arm/boot/dts/aspeed/Makefile > +++ b/arch/arm/boot/dts/aspeed/Makefile > @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-ast2600-evb.dtb \ > aspeed-bmc-amd-daytonax.dtb \ > aspeed-bmc-amd-ethanolx.dtb \ > + aspeed-bmc-amd-onyx.dtb \ > aspeed-bmc-ampere-mtjade.dtb \ > aspeed-bmc-ampere-mtmitchell.dtb \ > aspeed-bmc-arm-stardragon4800-rep2.dtb \ > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts > new file mode 100644 > index 000000000000..a7056cd29553 > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts > @@ -0,0 +1,98 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright (c) 2021 - 2024 AMD Inc. > +// Author: Supreeth Venkatesh > + > +/dts-v1/; > + > +#include "aspeed-g6.dtsi" > +#include > + > +/ { > + model = "AMD Onyx BMC"; > + compatible = "amd,onyx-bmc", "aspeed,ast2600"; > + > + aliases { > + serial0 = &uart1; > + serial4 = &uart5; > + }; > + > + chosen { > + stdout-path = &uart5; > + bootargs = "console=ttyS4,115200 earlyprintk vmalloc=512MB"; Why `vmalloc=512MB`? Can you add a comment explaining the need for that? That said, setting bootargs in the devicetree is generally discouraged. > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; > + > +}; > + > +&mdio0 { > + status = "okay"; > + > + ethphy0: ethernet-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0>; > + }; > +}; > + > +&mac3 { > + status = "okay"; > + phy-mode = "rgmii"; > + phy-handle = <ðphy0>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rgmii4_default>; > +}; > + > + > + > +&fmc { > + status = "okay"; > + flash@0 { > + compatible = "jedec,spi-nor"; > + status = "okay"; > + #include "openbmc-flash-layout-128.dtsi" > + }; > +}; > + > +//Host Console > +&uart1 { > + status = "okay"; > +}; How are you managing the host console? Enabling UART1 for that on the BMC piques my interest :) Apologies for the delay in reviewing. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel