linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock
Date: Mon, 9 May 2016 13:28:14 +0100	[thread overview]
Message-ID: <5730825E.5030101@linaro.org> (raw)
In-Reply-To: <1461173177-11930-3-git-send-email-van.freenix@gmail.com>

Thanks for the Ping, I totally missed this thread.

On 20/04/16 18:26, Peng Fan wrote:
> Before access ocotp nvmem area, the clock should be enabled.
> Or, `hexdump nvmem` will hang the system. So, use such flow:
> "
>    1. clock_enable_prepare
>    2. read nvmem ocotp area
>    3. clock_disable_unprepare
> "
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> ---
>
> V2:
>   Follow Fabio's comments, check return value of clk_prepare_enable
>
>   drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++-
>   1 file changed, 15 insertions(+), 1 deletion(-)

Changes to the driver looks good to me,
Only one comment, As the clock property is now made mandatory, you 
should update the dt-bindings with this info too.


thanks,
srini

  parent reply	other threads:[~2016-05-09 12:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 17:26 [PATCH V2 1/3] arm: dts: imx6qdl: add clocks property for ocotp node Peng Fan
2016-04-20 17:26 ` [PATCH V2 2/3] arm: dts: imx6sl: " Peng Fan
2016-04-20 17:26 ` [PATCH V2 3/3] nvmem: imx-ocotp: handling clock Peng Fan
2016-05-09 12:20   ` Peng Fan
2016-05-09 12:28   ` Srinivas Kandagatla [this message]
2016-05-09 12:41     ` Peng Fan
2016-05-10 10:31       ` Srinivas Kandagatla
2016-05-10 12:04         ` Peng Fan
2016-06-06  8:07 ` [PATCH V2 1/3] arm: dts: imx6qdl: add clocks property for ocotp node Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5730825E.5030101@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).