From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4F06C4167B for ; Thu, 30 Nov 2023 09:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ynUPZNNq3TvgQMFjzNj/sT9a8xNlwQVmw7VRxIJ3Lpg=; b=zCpWi9Pcy6PSXh E5xHmartrOkZ/Kmuea4BxLuQsD3qFXubVz/yG2AQSBG9QwScnmvvfeD2xOvvGgQ0Rhx7fhDAjn4tf enytgYQIobsQdVhyWcl7rlGv4pXCkqYQwDUIdUerppbEOrJy63uxbJkH0uSoTrErxMrkqz9Bwmbfo lMoQN5UpLapMTcex6VZpz5YofDsv5Uczzmvbat0f8EALsljRs+son7J/o/Q0phLEHtAhuPuN0jZuL iVMqFvSBd5tf+8OU+TD7lNiPVhZ1arjJcbliPH2EntCHEiz2cGj7/AHZswMf6mIcRhGBxnhh4P+iw DjoKHbzPDZkAKd13HFJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8dhn-00AMIo-0s; Thu, 30 Nov 2023 09:51:35 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8dhj-00AMI3-1b for linux-arm-kernel@lists.infradead.org; Thu, 30 Nov 2023 09:51:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1701337891; x=1732873891; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KwU8sh79wqm+8sbS+kXuTmgHNTBjtnFYoiNmANtujYc=; b=MknrtdJMcmITlX3TqStViHSJSSg51OFZorrTyr0xmGVgtG2+b8bKPLUP cN25ItGhJFgDYYP3MAgRoXnmKv4WDtYXbVB2GhurRoTNKxR81V5SPguIk 4FX00U3Sj9bDQJpIeS4HFyPmJgjW453szWHFR7WRkgbPelphliEsuNkEw 5u4mnhh+4TjgUNebVUKOgOUY+6oDIlzAADa0BY7CieFn6FToakCzDq9Zv hq4ZR7pJtiXkj+eTrO1rR53vG239hirc6QN5461H+7CThY73pXXF01/uW JtXCHLUL8ImOk+kyXGOal9UnQFYUg/oKyZtBf2JdufzbO76CpVeu0Gkz3 A==; X-IronPort-AV: E=Sophos;i="6.04,237,1695679200"; d="scan'208";a="34256164" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 30 Nov 2023 10:51:23 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 3F3CD280075; Thu, 30 Nov 2023 10:51:23 +0100 (CET) From: Alexander Stein To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Paul Elder , kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Tim Harvey , Philippe Schenker , Marek Vasut , Gregor Herburger , Marcel Ziswiler , open list , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: Add overlays for ISP instances Date: Thu, 30 Nov 2023 10:51:22 +0100 Message-ID: <5734628.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231129151637.GG24293@pendragon.ideasonboard.com> References: <20231129093113.255161-1-paul.elder@ideasonboard.com> <7122934.GXAFRqVoOG@steina-w> <20231129151637.GG24293@pendragon.ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_015131_848463_ACB441D1 X-CRM114-Status: GOOD ( 32.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > Hi Alexander, > = > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > From: Laurent Pinchart > > > = > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > > to the CSIS for now, bypassing the ISI completely. > > = > > I'm not sure if this is worth adding in a separate overlay. > = > The trouble is that, at this point, selection between the ISP and the > ISI can only be performed through DT :-S That's why this is implemented > as an overlay. I feel a better place would be the overlay which actually adds the sensor. = This knows best whether ISI or ISP should be used. > > > Signed-off-by: Laurent Pinchart > > > Signed-off-by: Paul Elder > > > --- > > > = > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++= ++ > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++= ++ > > > 3 files changed, 74 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > = > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > 300049037eb0..f97dfac11189 > > > 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-dhcom-pdk2.dtb > > > = > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-dhcom-pdk3.dtb > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-icore-mx8mp-edimm2.2.dtb > > > = > > > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-isp1.dtbo > > > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-isp2.dtbo > > > = > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-msc-sm2s-ep1.dtb > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-phyboard-pollux-rdk.dtb > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-tqma8mpql-mba8mpxl.dtb > > > = > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > > index 000000000000..cf394ed224ab > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > @@ -0,0 +1,36 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright 2022 Ideas on Board Oy > > > + */ > > > + > > > +/dts-v1/; > > > +/plugin/; > > > + > > > +#include > > > + > > > +&isi_0 { > > > + status =3D "disabled"; > > = > > ISI is disabled by default. What is your intention here? > = > It could be enabled by an overlay for a camera module. Ideally we want > to be able to enable both the ISI and ISP at runtime, but that's not > possible yet and will require a very large amount of work. Again IMHO this is part of sensor setup, in a very specific overlay. To put= it = into different words: I barely see the gain of this small overlay. Runtime switching would require a combined media controller including both = ISI = and ISP, no? Best regards, Alexander > > > + > > > + ports { > > > + port@0 { > > > + /delete-node/ endpoint; > > = > > This doesn't work in overlays. See [1]. Otherwise the OF graph connecti= ons > > look fine to me. I'm using the same in my local overlay. > = > Interesting, I wasn't aware of that. Maybe we should fix it :-) > = > > [1] > > https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=3DXHHM3RUN1cN= rcZB > > khsPZA@mail.gmail.com/> = > > > + }; > > > + }; > > > +}; > > > + > > > +&isp_0 { > > > + status =3D "okay"; > > > + > > > + ports { > > > + port@1 { > > > + isp0_in: endpoint { > > > + bus-type =3D ; > > > + remote-endpoint =3D <&mipi_csi_0_out>; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +&mipi_csi_0_out { > > > + remote-endpoint =3D <&isp0_in>; > > > +}; > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > > index 000000000000..14e2e7b2617f > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > @@ -0,0 +1,36 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright 2022 Ideas on Board Oy > > > + */ > > > + > > > +/dts-v1/; > > > +/plugin/; > > > + > > > +#include > > > + > > > +&isi_0 { > > > + status =3D "disabled"; > > > + > > > + ports { > > > + port@1 { > > > + /delete-node/ endpoint; > > > + }; > > > + }; > > > +}; > > > + > > > +&isp_1 { > > > + status =3D "okay"; > > > + > > > + ports { > > > + port@1 { > > > + isp1_in: endpoint { > > > + bus-type =3D ; > > > + remote-endpoint =3D <&mipi_csi_1_out>; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +&mipi_csi_1_out { > > > + remote-endpoint =3D <&isp1_in>; > > > +}; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel