From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: samsung: improve static dma_mask definition
Date: Wed, 18 May 2016 17:01:22 +0200 [thread overview]
Message-ID: <573C83C2.5090203@samsung.com> (raw)
In-Reply-To: <1463042333-281444-1-git-send-email-arnd@arndb.de>
On 05/12/2016 10:38 AM, Arnd Bergmann wrote:
> When no DMA master devices are part of the kernel configuration,
> we get a warning about the unused dma mask definition:
>
> arch/arm/plat-samsung/devs.c:71:12: error: 'samsung_device_dma_mask' defined but not used [-Werror=unused-variable]
> static u64 samsung_device_dma_mask = DMA_BIT_MASK(32);
>
> We could simply mark this as __maybe_unused to shut up that warning,
> but a nicer solution seems to be to have a separate mask for each
> device. The advantage is that a driver that happens to call
> dma_set_mask() on one device doesn't implicitly change the mask
> for the other devices as well. This is more of a theoretical
> problem, as obviously nothing does it for the devices in this
> file (or they would have always been broken), but it feels
> cleaner that way.
>
> The definition works by creating an array in place so we can take
> the address of it and let the compiler generate a hidden symbol
> for it at compile time.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/plat-samsung/devs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, although does not look as critical fix but less warnings makes
spotting right issues faster so applied for v4.7.
Best regards,
Krzysztof
prev parent reply other threads:[~2016-05-18 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 8:38 [PATCH] ARM: samsung: improve static dma_mask definition Arnd Bergmann
2016-05-18 15:01 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573C83C2.5090203@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).