From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI
Date: Mon, 23 May 2016 22:25:17 -0400 [thread overview]
Message-ID: <5743BB8D.7050408@codeaurora.org> (raw)
In-Reply-To: <57431FF7.2060807@linaro.org>
On 5/23/2016 11:21 AM, Eric Auger wrote:
>> + acpi_ret = acpi_evaluate_integer(handle, "_RST", NULL, &val);
>> > + if (ACPI_FAILURE(acpi_ret))
>> > + return -EINVAL;
> Can't you return something more explicit here? The error code will be
> visible to the userspace. Difficult for him to understand the cause of
> the failure in that case.
I can also add a reset failed message to both DT and ACPI reset calls.
Will that work?
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-05-24 2:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 2:13 [PATCH V5 0/6] vfio, platform: add ACPI support Sinan Kaya
2016-05-16 2:13 ` [PATCH V5 1/6] vfio: platform: rename reset function Sinan Kaya
2016-05-23 12:52 ` Eric Auger
2016-05-16 2:13 ` [PATCH V5 2/6] vfio: platform: move reset call to a common function Sinan Kaya
2016-05-23 13:02 ` Eric Auger
2016-05-24 2:14 ` Sinan Kaya
2016-05-16 2:13 ` [PATCH V5 3/6] vfio: platform: determine reset capability Sinan Kaya
2016-05-23 13:16 ` Eric Auger
2016-05-16 2:13 ` [PATCH V5 4/6] vfio: platform: add support for ACPI probe Sinan Kaya
2016-05-23 13:18 ` Eric Auger
2016-05-24 2:18 ` Sinan Kaya
2016-06-07 16:33 ` Auger Eric
2016-05-16 2:13 ` [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Sinan Kaya
2016-05-23 14:41 ` Eric Auger
2016-05-24 2:23 ` Sinan Kaya
2016-05-23 15:21 ` Eric Auger
2016-05-24 2:25 ` Sinan Kaya [this message]
2016-05-16 2:13 ` [PATCH V5 6/6] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-05-23 15:20 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743BB8D.7050408@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).