From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension()
Date: Fri, 12 Oct 2018 16:45:35 +0100 [thread overview]
Message-ID: <5743b2ce-232f-f7e9-b5e7-3fd017575d78@arm.com> (raw)
In-Reply-To: <1539284855-4035-2-git-send-email-gengdongjiu@huawei.com>
Hi Dongjiu Geng,
On 11/10/2018 20:07, Dongjiu Geng wrote:
> Rename kvm_arch_dev_ioctl_check_extension() to
> kvm_arch_vm_ioctl_check_extension(), because it does
> not have any relationship with device.
>
> Renaming this function can make code readable.
Lots of things in the kernel are misnamed, its not normally worth fixing them.
But it confused me, so:
Acked-by: James Morse <james.morse@arm.com>
Thanks,
James
next prev parent reply other threads:[~2018-10-12 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 19:07 [PATCH v3 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng
2018-10-11 19:07 ` [PATCH v3 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng
2018-10-12 15:45 ` James Morse [this message]
2018-10-11 19:07 ` [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng
2018-10-12 11:35 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743b2ce-232f-f7e9-b5e7-3fd017575d78@arm.com \
--to=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).