From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85677CCA46C for ; Fri, 16 Oct 2026 16:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rzDIQw6h4NECMqKciLXPkVXDGpsarl8SfpMM/RlbL/M=; b=M9as6CBgJJsS/v34JfBl6WqP8M kvtF5Th9jbzUcZL0FRVrrOzx8+FHn1jOfPgbnTpYnhiBOxzTRTUUu2v9kzQDav2kSQ2yzsh5f1XAV Dy6AsQ4fuEKvnl8N6dUFtHFz/qAYND9N6GmwntPoUmLCAGuxhD4G8DZYm9UMQQEehurlNzVFt1bB4 K+z0MzNFMRsWS/La8H1tBeHLF2G7OvFARqB+dhkdWFLcyVT4pGdmXBcRfSbcC4qrDJplHn9cmcEDY ICEwtxF7MkEfalcPRbzD7165HcrIsJfH7Ycf2EJp25LZObRx3/CFGKp7VEpSAv9jA71kVTv2czacP rsiLsPHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHkc2-00000003PjG-1ebc; Fri, 16 Oct 2026 16:16:54 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHkby-00000003PiU-3dGT for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2026 16:16:52 +0000 Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4494B1400146 for ; Fri, 16 Oct 2026 12:16:49 -0400 (EDT) Received: from ams-imap-03 ([10.64.2.23]) by ams-compute-02.internal (MEProxy); Fri, 16 Oct 2026 12:16:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1792167405; x=1792253805; bh=rzDIQw6h4NECMqKciLXPkVXDGpsarl8SfpMM/RlbL/M=; b= iwuG1InxKakBgP7fRT9+0Q7WQtZLLw5iRywDPeL3AI6awnAVB8y2DjrGDeZJIe7n zNqFWdu0ZKqWJF401Iaf+lktSsGTdnE9zl6KvyOvmrkfyiITePNlVzuwyACqH0ZK 2NUpkgq7HnqBKYngjVyF1xKZGxsIUhbg43WblU2uq8gNOb8XA5RvYt462k0ZFFsP XLrR3E/uqQ+/J7Wanv5YYsIXXjfjYz2lRiltjsyu/LWB0dslqMJlv5RN9BdwWrhQ JLRyXX8thZLmnHOLZOjximvVhE/Hz/gXozrzNkgOVq1nAqDifo4h9TWS6gPD1E3I tvdnsYM9iugj2uxQyJou2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1792167405; x= 1792253805; bh=rzDIQw6h4NECMqKciLXPkVXDGpsarl8SfpMM/RlbL/M=; b=d nAiEPQ4CkKI0vgyPOchYaua3hqJ8nDWf245kIRRU+08vE0LtLqKhWkIceOHzokHE O0vQk6pvNQk5FLW+wbtl4jq8CfBFoxs5a4TpO1OclLY7zzjq2zpRUkaPfabx5At3 g2yD7V747dTSkOv0lM0+tUoVrOr7TdCjbVjnxcKn7SLVDuriN7bblFgPkktEuLpM e1CTJnSmr8dTo/c4XBUDDYlkRYQq+wNE+xWIXR4yoPZ6NquEN16DyaelA4BXwre2 IvuXqyg7kaU5/w0HOof4Mu1nXSDKaO/5tsj3ptfZO0SnmHRmVog3ydMIVGoYFcYl iboh0PYMlUGibBb8p2myg== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=sign d=arndb.de a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792167405; d=arndb.de; mf=PGFybmRAYXJuZGIuZGU+; rt=PGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZz4=; s=fm1:rsa-sha256:h00ltmIn33mEGgggilzrmkwEI7b/nzoytS2CQbBOTeuXF3I v7L51JNZyGhNnISThPGEFFoH1Yf0tJksNu/0Nj/4fhgCu63AsaKBJ4n0m0MjfBc+ ligL5/X50rCb9YQDfzoAUyY1+Yc9+JMCszws3iYW0Hfm20FWzcXeIq4Cb8GU1xvP 3XFxyrMrGsWQlcnD2A1LF5QWlvVLd4KkIxQIGC4W6Kv6xPNtaA4w9MloXB+yNO08 tYbeDMJj2Ju4deosbDEwFWXKnQC3xShtk/jTc+Cn3W+Ik3q0Lut6C5FYBB8xQoB4 fc7urpzJKSYpE49jZ8X/GWcrUI86lypSvC8LubA==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:EW6Ujl8vplrbtqeoPFBe3RxPQq6XEhz/1LxpfCwfpFM=:mQDmWQYO3ZoFImkk166fHrJ4M/bc+UFOiE7tflbCqAk=; X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFmYhpPEy0XQM040EQO/1o4r3h5nElx6hPDkkJqVhUiVqgTg8tNbP8FEYoNbTUm50 c30Ur18QKQ4DS4kne48uGyWifm5vqa+/ec/+SWtL/G0QYzMQxG2No5lRGMvNha7tzDsh0Z 6ZG5a1k9KRFNykIGO8DnwChNJgiRyVCyWZHUIjn/kc8CPCqTFYE9fNNyPHTgQKe6cy+ESy H6D8oxOWB6QYRRVMYz8414tP2JUjjUug6ehKrBMxdckvAM1uLs4BLSDdaoEr9NOTYZJn5o K3Zn41lItAk19HwTUAXClwsXqjGseMTOGd+wh21TmcUxoXgHSFphkA0+RjnmKV6qudAgdM FtDZO9pPZz2yNTK5jrrsju3XuQ7dYc8BAssPIEcveiyNlWWP0QEJixfx3d1imeU3v8MCLu bllw2C1LO9bMKGMbl3NB8d96Gfw2sPhzltGhuCJ2ZS/x6SWn4EV3b0/RrfgjSq7y+8Udt/ cEo52dB9A/zCJRv4Msg7jkygZv7oqEUyU8Sm8EpM1LxCv6jkv2TrIUS0sKaUyVUePX8ndf xKTeLrCw1UWFRyYy/jSiXM5fKixH4Io8oFLDO98kvVtwyX2XwkJ+F/iSJwOBJrFhgHKQ5f 84oxo+8p7QJNdR3G5kkx5w0zCFt4c3pnTAs+upii5jvkmHJqE+tjm8PzGgRw X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id A23BB32A008E; Fri, 16 Oct 2026 12:16:40 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: A4WN0AQLOakc Date: Fri, 16 Oct 2026 18:16:20 +0200 From: "Arnd Bergmann" To: "Hugo Villeneuve" , "Arnd Bergmann" Cc: "Greg Kroah-Hartman" , "Jiri Slaby" , "Andy Shevchenko" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Hugo Villeneuve" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Message-Id: <5743b352-ffa2-4d38-9abb-a06085dea56d@app.fastmail.com> In-Reply-To: <20261016115604.a89ef44986bb3620c327feaf@hugovil.com> References: <20261016130328.1037616-1-arnd@kernel.org> <20261016115604.a89ef44986bb3620c327feaf@hugovil.com> Subject: Re: [PATCH 1/2] tty: serial: remove hub6 multiport support Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261016_091651_281130_53EF5D99 X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2026, at 17:56, Hugo Villeneuve wrote: > On Fri, 16 Oct 2026 14:59:47 +0200 >> retinfo->custom_divisor = uport->custom_divisor; >> - retinfo->hub6 = uport->hub6; >> + retinfo->hub6 = 0; > > Would a comment here help? > > retinfo->hub6 = 0; /* No longer supported */ Good idea, added. >> @@ -924,7 +921,6 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port, >> change_port = !(uport->flags & UPF_FIXED_PORT) >> && (new_port != uport->iobase || >> (unsigned long)new_info->iomem_base != uport->mapbase || >> - new_info->hub6 != uport->hub6 || > > Maybe keep this so that change_port is true if someone sets hub6 to a > value other than zero (see below)? Right, this would be fairly harmless as nothing looks at the field afterwards but it makes sense for consistency. I've moved the hub6 check up before change_port now to behave the same way for regular users and root: @@ -935,6 +935,11 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port, if (uartclk == 0) return -EINVAL; } + + /* hub6 is no longer supported */ + if (new_info->hub6 != 0) + return -EINVAL; + if (!capable(CAP_SYS_ADMIN)) { if (change_irq || change_port || (new_info->baud_base != uport->uartclk / 16) || @@ -950,10 +955,6 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port, goto check_and_exit; } - /* hub6 is no longer supported */ - if (new_info->hub6 != 0) - return -EINVAL; - if (change_irq || change_port) { retval = security_locked_down(LOCKDOWN_TIOCSSERIAL); if (retval) Thanks for taking a look! Arnd