From: sudipm.mukherjee@gmail.com (Sudip Mukherjee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwrng: stm32 - fix build warning
Date: Fri, 27 May 2016 14:30:48 +0530 [thread overview]
Message-ID: <57480CC0.80500@gmail.com> (raw)
In-Reply-To: <7211115.EdoBLRGZ1i@wuerfel>
On Wednesday 25 May 2016 03:36 PM, Arnd Bergmann wrote:
> On Wednesday, May 25, 2016 7:35:17 AM CEST Sudip Mukherjee wrote:
>> On Tuesday 24 May 2016 02:05 AM, Arnd Bergmann wrote:
>>> On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote:
>>>> We have been getting build warning about:
>>>> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read':
>>>> drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used
>>>> uninitialized in this function
>>>>
>>>> On checking the code it turns out that sr can never be used
>>>> uninitialized as sr is getting initialized in the while loop and while
>>>> loop will always execute as the minimum value of max can be 32.
>>>> So just initialize sr to 0 while declaring it to silence the compiler.
>>>>
>>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>>> ---
>>>
>snip>
>
> BTW, regarding your build infrastructure, I'd also recommend building
> with 'make -s' to make the output more compact.
travis is having a timeout and if there is no output from the build
within a time limit then it will cancel the build. I can use the option
if i can increase the timeout limit. I will have a look at the options.
Thanks for the idea.
Regards
Sudip
prev parent reply other threads:[~2016-05-27 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 12:44 [PATCH] hwrng: stm32 - fix build warning Sudip Mukherjee
2016-05-23 20:35 ` Arnd Bergmann
2016-05-24 7:59 ` Maxime Coquelin
2016-05-24 8:32 ` Arnd Bergmann
2016-05-24 8:50 ` Maxime Coquelin
2016-05-24 8:58 ` Arnd Bergmann
2016-05-24 9:20 ` Maxime Coquelin
2016-05-25 2:00 ` Sudip Mukherjee
2016-05-24 10:09 ` Daniel Thompson
2016-05-24 10:57 ` Maxime Coquelin
2016-05-25 2:05 ` Sudip Mukherjee
2016-05-25 10:06 ` Arnd Bergmann
2016-05-27 9:00 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57480CC0.80500@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).