From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 5/6] dtb: xgene: Remove clock nodes
Date: Mon, 30 May 2016 09:34:00 +0200 [thread overview]
Message-ID: <574BECE8.2050307@gmail.com> (raw)
In-Reply-To: <1464333768-26150-6-git-send-email-isubramanian@apm.com>
On 27/05/16 09:22, Iyappan Subramanian wrote:
> Since the MDIO will be responsible for clock reset, removing the clock
> nodes from shadowcat xge0 and storm sgenet1.
>
> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
> Tested-by: Fushen Chen <fchen@apm.com>
> Tested-by: Toan Le <toanle@apm.com>
> ---
> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 12 ------------
> arch/arm64/boot/dts/apm/apm-storm.dtsi | 18 ++++--------------
> 2 files changed, 4 insertions(+), 26 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> index 8106957..f27563d 100644
> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> @@ -299,17 +299,6 @@
> clock-output-names = "pcie1clk";
> };
>
> - xge0clk: xge0clk at 1f61c000 {
> - compatible = "apm,xgene-device-clock";
> - #clock-cells = <1>;
> - clocks = <&socplldiv2 0>;
> - reg = <0x0 0x1f61c000 0x0 0x1000>;
> - reg-names = "csr-reg";
> - enable-mask = <0x3>;
> - csr-mask = <0x3>;
> - clock-output-names = "xge0clk";
> - };
> -
mdio at 0x1f610000 has xge0clk as input (patch 4), so deleting the node
here will break the device tree. I suppose the mdio consumes the
menetclk as in apm-storm.dtsi.
Regards,
Matthias
> xge1clk: xge1clk at 1f62c000 {
> compatible = "apm,xgene-device-clock";
> #clock-cells = <1>;
> @@ -643,7 +632,6 @@
> interrupts = <0 96 4>,
> <0 97 4>;
> dma-coherent;
> - clocks = <&xge0clk 0>;
> local-mac-address = [00 01 73 00 00 01];
> phy-connection-type = "sgmii";
> phy-handle = <&sgenet0phy>;
> diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> index 18f694ea..f631fe4 100644
> --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> @@ -237,20 +237,11 @@
> clocks = <&socplldiv2 0>;
> reg = <0x0 0x1f21c000 0x0 0x1000>;
> reg-names = "csr-reg";
> - csr-mask = <0x3>;
> + csr-mask = <0xa>;
> + enable-mask = <0xf>;
> clock-output-names = "sge0clk";
> };
>
> - sge1clk: sge1clk at 1f21c000 {
> - compatible = "apm,xgene-device-clock";
> - #clock-cells = <1>;
> - clocks = <&socplldiv2 0>;
> - reg = <0x0 0x1f21c000 0x0 0x1000>;
> - reg-names = "csr-reg";
> - csr-mask = <0xc>;
> - clock-output-names = "sge1clk";
> - };
> -
> xge0clk: xge0clk at 1f61c000 {
> compatible = "apm,xgene-device-clock";
> #clock-cells = <1>;
> @@ -938,9 +929,9 @@
> reg-names = "enet_csr", "ring_csr", "ring_cmd";
> interrupts = <0x0 0x3c 0x4>;
> dma-coherent;
> - clocks = <&menetclk 0>;
> /* mac address will be overwritten by the bootloader */
> local-mac-address = [00 00 00 00 00 00];
> + clocks = <&menetclk 0>;
> phy-connection-type = "rgmii";
> phy-handle = <&menetphy>;
> };
> @@ -955,8 +946,8 @@
> interrupts = <0x0 0xA0 0x4>,
> <0x0 0xA1 0x4>;
> dma-coherent;
> - clocks = <&sge0clk 0>;
> local-mac-address = [00 00 00 00 00 00];
> + clocks = <&sge0clk 0>;
> phy-connection-type = "sgmii";
> phy-handle = <&sgenet0phy>;
> };
> @@ -972,7 +963,6 @@
> <0x0 0xAD 0x4>;
> port-id = <1>;
> dma-coherent;
> - clocks = <&sge1clk 0>;
> local-mac-address = [00 00 00 00 00 00];
> phy-connection-type = "sgmii";
> phy-handle = <&sgenet1phy>;
>
next prev parent reply other threads:[~2016-05-30 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 7:22 [PATCH v1 0/6] drivers: net: xgene: Fix 1G hot-plug and module support Iyappan Subramanian
2016-05-27 7:22 ` [PATCH v1 1/6] drivers: net: xgene: MAC and PHY configuration changes Iyappan Subramanian
2016-05-27 17:07 ` Matthias Brugger
2016-05-27 7:22 ` [PATCH v1 2/6] drivers: net: xgene: Backward compatibility with older firmware Iyappan Subramanian
2016-05-27 7:22 ` [PATCH v1 3/6] drivers: net: phy: Add MDIO driver Iyappan Subramanian
2016-05-27 7:22 ` [PATCH v1 4/6] dtb: xgene: Add MDIO node Iyappan Subramanian
2016-05-27 7:22 ` [PATCH v1 5/6] dtb: xgene: Remove clock nodes Iyappan Subramanian
2016-05-30 7:34 ` Matthias Brugger [this message]
2016-05-31 23:44 ` Iyappan Subramanian
2016-05-27 7:22 ` [PATCH v1 6/6] drivers: net: xgene: Fix module load/unload crash Iyappan Subramanian
2016-05-27 17:07 ` [PATCH v1 0/6] drivers: net: xgene: Fix 1G hot-plug and module support Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574BECE8.2050307@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).