From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer
Date: Wed, 1 Jun 2016 09:58:46 +0200 [thread overview]
Message-ID: <574E95B6.801@baylibre.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1606010902260.3629@nanos>
On 06/01/2016 09:03 AM, Thomas Gleixner wrote:
> On Tue, 31 May 2016, Neil Armstrong wrote:
>> +static int oxnas_rps_timer_shutdown(struct clock_event_device *evt)
>> +{
>> + struct oxnas_rps_timer *rps =
>> + container_of(evt, struct oxnas_rps_timer, clkevent);
>> +
>> + if (!clockevent_state_periodic(evt))
>> + return 0;
>
> So if the timer is in oneshot mode, then you just leave it enabled. What's the
> rationale of this?
Indeed, there is no rationale.
Fixed in v2.
>> +
>> + oxnas_rps_timer_config(rps, 0, 0);
>
> Thanks,
>
> tglx
>
Thanks,
Neil
next prev parent reply other threads:[~2016-06-01 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 9:49 [PATCH 0/2] clocksource: Add support for Oxford Semiconductor RPS Dual Timer Neil Armstrong
2016-05-31 9:49 ` [PATCH 1/2] clocksource: Add " Neil Armstrong
2016-06-01 7:03 ` Thomas Gleixner
2016-06-01 7:58 ` Neil Armstrong [this message]
2016-05-31 9:49 ` [PATCH 2/2] dt-bindings: clocksource: Add Add Oxford Semiconductor RPS Timer bindings Neil Armstrong
2016-06-02 23:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574E95B6.801@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).