From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] dt-bindings: pwm: Add MediaTek display PWM bindings
Date: Fri, 3 Jun 2016 17:03:53 +0200 [thread overview]
Message-ID: <57519C59.5040107@gmail.com> (raw)
In-Reply-To: <1464936349.5209.9.camel@mhfsdcap03>
On 03/06/16 08:45, weiqing kong wrote:
> On Thu, 2016-06-02 at 17:45 -0500, Rob Herring wrote:
>> On Mon, May 30, 2016 at 04:41:50PM +0800, Weiqing Kong wrote:
>>> Add MT2701 compatible string.
>>>
>>> Signed-off-by: Weiqing Kong <weiqing.kong@mediatek.com>
>>> ---
>>> Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>>> index f8f59ba..f2f2fa9 100644
>>> --- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>>> @@ -1,9 +1,10 @@
>>> MediaTek display PWM controller
>>>
>>> Required properties:
>>> - - compatible: should be "mediatek,<name>-disp-pwm":
>>> - - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
>>> + - compatible: should be like these:
>>> + - "mediatek,mt2701-disp-bls": found on mt2701 SoC.
>>
>> Why bls instead of pwm?
>
> In mt6595/mt8173, we have a hardware module named pwm.
> In mt2701, we have bls hardware module which includes disp pwm function,
> so we named it mt2701-disp-bls rather than mt2701-disp-pwm in order to
> match with hardware spec.
> thanks.
>
From what I understand pwm module and disp pwm in mt6589/mt8173 is
independent from the disp pwm. Actually the disp pwm in mt6589 is part
of the bls module, so this should me mediatek,mt2701-disp-pwm as well
Thanks,
Matthias
>>
>>> - "mediatek,mt6595-disp-pwm": found on mt6595 SoC.
>>> + - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
>>> - reg: physical base address and length of the controller's registers.
>>> - #pwm-cells: must be 2. See pwm.txt in this directory for a description of
>>> the cell format.
>>> --
>>> 1.8.1.1.dirty
>>>
>
>
next prev parent reply other threads:[~2016-06-03 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 8:41 [PATCH RESEND 0/3] Support Mediatek Soc MT2701 disp pwm Weiqing Kong
2016-05-30 8:41 ` [PATCH 1/3] dt-bindings: pwm: Add MediaTek display PWM bindings Weiqing Kong
2016-06-02 22:45 ` Rob Herring
2016-06-03 6:45 ` weiqing kong
2016-06-03 15:03 ` Matthias Brugger [this message]
2016-06-08 6:48 ` weiqing kong
2016-05-30 8:41 ` [PATCH 2/3] pwm: Add MediaTek MT2701 display PWM driver support Weiqing Kong
2016-06-03 15:35 ` Matthias Brugger
2016-06-08 7:21 ` weiqing kong
2016-06-08 11:22 ` Matthias Brugger
2016-06-08 12:05 ` weiqing kong
2016-05-30 8:41 ` [PATCH 3/3] dts: Add disp bls dsti and dts config for MT2701 Weiqing Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57519C59.5040107@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).