From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 181F1C433F5 for ; Tue, 12 Oct 2021 17:56:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6E6860EFE for ; Tue, 12 Oct 2021 17:56:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6E6860EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=z3ntu.xyz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n+RzRjJFF6kYeFl8LTCwXYUurxsIA1nBx/14utV805s=; b=UyYS0blmnrdDVu a/pl9V4bVfXnTkmu+sOV9o3TgLlmdd2MbmtkBh6M/O4mCRE8bsz8hrqXzOHGmZkn/xyOc6KRZIAjF QCMtmtXwNZRWadnn66elvOTSsBTaWFcAXqRDqlCCcpir+Jr63kTk/Y4m6AI43dzH8WJiJiUB1doJP TjozdI2r3RMAm+9o2shZlCa41Vw9wrdRoGdZ7RyDZ5aypjBAQbWlmtkzq1wQBJLnlVzsZ1vGPVxLD VhShN0ehCiBeuHXUdiz9wIlLzTSgd7MyvSEd6pa4ib0v5xDc+dm4tlBk/Flv6K/lBOrEIIhewKAZ+ LROsH/GBKRPVTSgAx5HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maLzM-00Delr-QZ; Tue, 12 Oct 2021 17:54:56 +0000 Received: from mail.z3ntu.xyz ([128.199.32.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maLzI-00Dek8-JO; Tue, 12 Oct 2021 17:54:54 +0000 Received: from g550jk.localnet (unknown [62.240.134.74]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 493A6C9740; Tue, 12 Oct 2021 17:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1634061284; bh=vw/u1+TRdbPbMlWhcKJ4P6ntQXXSxoIiYsV1GYAXpDs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EszIvTl8z/YYB8i9IdSQ7Z76+m2YEuxr3PMJR+fXCfYcDwb2ob5fYnKjks+FvKxZ9 BenrzW5z5PIl0OEBejVr2nfL01SYY2R9UekBHsiD38G1bpMqb2xWhdpygoh7gFAut7 MdaJmhMQ9XnPcwJSuHVQ+ZpEglW07L7ts5PvFbTw= From: Luca Weiss To: linux-mediatek@lists.infradead.org, Matthias Brugger List-Id: Cc: ~postmarketos/upstreaming@lists.sr.ht, Arnd Bergmann , Enric Balletbo i Serra , Fabien Parent , Hsin-Yi Wang , Olof Johansson , Rob Herring , Sean Wang , Seiya Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, soc@kernel.org Subject: Re: [PATCH 2/2] arm: dts: mt6589: Add device tree for Fairphone 1 Date: Tue, 12 Oct 2021 19:54:38 +0200 Message-ID: <5755444.lOV4Wx5bFT@g550jk> In-Reply-To: <686404ce-2e0b-5470-b095-1c1fd7c18250@gmail.com> References: <20211005202833.96526-1-luca@z3ntu.xyz> <20211005202833.96526-2-luca@z3ntu.xyz> <686404ce-2e0b-5470-b095-1c1fd7c18250@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_105452_844481_3D1E1049 X-CRM114-Status: GOOD ( 31.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Matthias, On Freitag, 8. Oktober 2021 13:49:25 CEST Matthias Brugger wrote: > On 05/10/2021 22:28, Luca Weiss wrote: > > Add rudimentary support for the Fairphone 1, based on MT6589 to boot to > > UART console. > > > > The recently added SMP support needs to be disabled for this board as > > the kernel panics executing /init with it, even though the CPUs seem to > > start up fine - maybe a stability issue. > > > > [ 0.072010] smp: Bringing up secondary CPUs ... > > [ 0.131888] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001 > > [ 0.191889] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002 > > [ 0.251890] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003 > > [ 0.251982] smp: Brought up 1 node, 4 CPUs > > [ 0.254745] SMP: Total of 4 processors activated (7982.28 BogoMIPS). > > [ 0.255582] CPU: All CPU(s) started in SVC mode. > > > > [ 0.472039] Run /init as init process > > [ 0.473317] Kernel panic - not syncing: Attempted to kill init! > > exitcode=0x00000004 > Would be nice to find out why. Did you tried to boot the system with > enable-method set but with bringing up just one or two cpus? Answered further down. > > > Signed-off-by: Luca Weiss > > --- > > > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/mt6589-fairphone-fp1.dts | 30 ++++++++++++++++++++++ > > 2 files changed, 31 insertions(+) > > create mode 100644 arch/arm/boot/dts/mt6589-fairphone-fp1.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 7e0934180724..24f402db2613 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1437,6 +1437,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \ > > > > mt2701-evb.dtb \ > > mt6580-evbp1.dtb \ > > mt6589-aquaris5.dtb \ > > > > + mt6589-fairphone-fp1.dtb \ > > > > mt6592-evb.dtb \ > > mt7623a-rfb-emmc.dtb \ > > mt7623a-rfb-nand.dtb \ > > > > diff --git a/arch/arm/boot/dts/mt6589-fairphone-fp1.dts > > b/arch/arm/boot/dts/mt6589-fairphone-fp1.dts new file mode 100644 > > index 000000000000..32c14ecf2244 > > --- /dev/null > > +++ b/arch/arm/boot/dts/mt6589-fairphone-fp1.dts > > @@ -0,0 +1,30 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2021, Luca Weiss > > + */ > > + > > +/dts-v1/; > > +#include "mt6589.dtsi" > > + > > +/ { > > + model = "Fairphone 1"; > > + compatible = "fairphone,fp1", "mediatek,mt6589"; > > + > > + chosen { > > + stdout-path = &uart3; > > + }; > > + > > + cpus { > > I'd expected "&cpus" why can we overwrite delete the node property like this > here? Both results in the same, dtc just merges everything together, so as long as the node name is identical, it works. Also I cannot use &cpus because cpus in mt6589.dtsi doesn't have a label set. Regarding SMP: I have tried setting maxcpus=2 in cmdline and that still makes the kernel panic. With maxcpus=1 and leaving the deleting out of the dts the kernel is stable and works properly. So I think it's better to leave this out of the dts and keep maxcpus=1 in cmdline (until this gets fixed). I've also heard from the person adding enable-method to mt6589.dtsi that it still works on their board, so something's different, maybe a different SoC revision, different bootloader behavior or whatever. If that's fine with you, I'll send a v2 with that fixed. > > + /* SMP is not stable on this board, makes the kernel panic */ > > + /delete-property/ enable-method; > > + }; > > + > > + memory { Also I was told off-list that this should be called memory@80000000 because of the reg, will fix in v2. Regards Luca > > + device_type = "memory"; > > + reg = <0x80000000 0x40000000>; > > + }; > > +}; > > + > > +&uart3 { > > + status = "okay"; > > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel