linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grinberg@compulab.co.il (Igor Grinberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: dts: utilite-pro: add mmc card slot support
Date: Wed, 15 Jun 2016 09:40:01 +0300	[thread overview]
Message-ID: <5760F841.4010307@compulab.co.il> (raw)
In-Reply-To: <c25d8e5d113240c5ab78771f301d901a@rwthex-s1-b.rwth-ad.de>

Hi Christopher,

On 06/13/2016 02:24 AM, christopher.spinrath at rwth-aachen.de wrote:
> From: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> 
> The Utilite Pro has a mmc card slot connected to the usdhc3
> controller. There is no card detection until hardware revision 1.3.
> 
> Add support for it and signal the controller with the broken-cd
> property that polling has to be used to detect a card.
> 
> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> 
> Notes:
>     Changes since v2:
>      - add Fabio's Reviewed-By
>     
>     Changes since v1:
>      - enhance commit message to explain to the broken-cd property
> 
>  arch/arm/boot/dts/imx6q-utilite-pro.dts | 44 +++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-utilite-pro.dts b/arch/arm/boot/dts/imx6q-utilite-pro.dts
> index 7219745..6199063 100644
> --- a/arch/arm/boot/dts/imx6q-utilite-pro.dts
> +++ b/arch/arm/boot/dts/imx6q-utilite-pro.dts

[...]

> @@ -151,3 +184,14 @@
>  	uart-has-rtscts;
>  	status = "okay";
>  };
> +
> +&usdhc3 {
> +	pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +	pinctrl-0 = <&pinctrl_usdhc3>;
> +	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> +	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> +	no-1-8-v;
> +	broken-cd;

A wast majority of boards produced are of revision >=1.3.
Can we please have the default as revision 1.3 with cd?
And let the patch you have submitted to U-Boot do the job
for older revisions?

> +	keep-power-in-suspend;
> +	status = "okay";
> +};
> 

-- 
Regards,
Igor.

  reply	other threads:[~2016-06-15  6:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160612232456.1621-1-christopher.spinrath@rwth-aachen.de>
2016-06-12 23:24 ` [PATCH v3 2/2] ARM: dts: utilite-pro: add mmc card slot support christopher.spinrath at rwth-aachen.de
2016-06-15  6:40   ` Igor Grinberg [this message]
     [not found]   ` <089d827c9de9426eab79a907a2043828@rwthex-s1-a.rwth-ad.de>
2016-06-15  9:16     ` Christopher Spinrath
2016-06-15 10:33       ` Igor Grinberg
     [not found]       ` <575994a0ec924e2db7282a2945d3355f@rwthex-s2-b.rwth-ad.de>
2016-06-15 14:40         ` Christopher Spinrath
2016-06-16  1:42           ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5760F841.4010307@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).