From mboxrd@z Thu Jan 1 00:00:00 1970 From: tthayer@opensource.altera.com (Thor Thayer) Date: Thu, 16 Jun 2016 14:12:29 -0500 Subject: [PATCHv3 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding In-Reply-To: <20160616183953.GA6667@rob-hp-laptop> References: <1465852752-11018-1-git-send-email-tthayer@opensource.altera.com> <1465852752-11018-5-git-send-email-tthayer@opensource.altera.com> <20160616183953.GA6667@rob-hp-laptop> Message-ID: <5762FA1D.7020606@opensource.altera.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, On 06/16/2016 01:39 PM, Rob Herring wrote: > On Mon, Jun 13, 2016 at 04:19:09PM -0500, tthayer at opensource.altera.com wrote: >> From: Thor Thayer >> >> Add the device tree bindings needed to support the Altera Ethernet >> FIFO buffers on the Arria10 chip. >> >> Signed-off-by: Thor Thayer >> --- >> v2 No Change >> v3 Change to common compatible string based on maintainer comments >> Add local IRQ values. >> --- >> .../bindings/arm/altera/socfpga-eccmgr.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt >> index 15eb0df..e9febbb 100644 >> --- a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt >> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt >> @@ -82,6 +82,14 @@ Required Properties: >> - interrupts : Should be single bit error interrupt, then double bit error >> interrupt, in this order. >> >> +Ethernet FIFO ECC >> +Required Properties: >> +- compatible : Should be "altr,socfpga-eth-mac-ecc" >> +- reg : Address and size for ECC block registers. >> > > parent is too vague. How about altr,ethernet-mac. > OK. I'll change to this. +- parent : phandle to parent altr,ethernet-mac node Thanks for reviewing! >> +- interrupts : Should be single bit error interrupt, then double bit error >> + interrupt, in this order. >> + >> Example: >> >> eccmgr: eccmgr at ffd06000 { >> @@ -108,4 +116,20 @@ Example: >> interrupts = <1 IRQ_TYPE_LEVEL_HIGH>, >> <33 IRQ_TYPE_LEVEL_HIGH> ; >> }; >> + >> + emac0-rx-ecc at ff8c0800 { >> + compatible = "altr,socfpga-eth-mac-ecc"; >> + reg = <0xff8c0800 0x400>; >> + parent = <&gmac0>; >> + interrupts = <4 IRQ_TYPE_LEVEL_HIGH>, >> + <36 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + >> + emac0-tx-ecc at ff8c0c00 { >> + compatible = "altr,socfpga-eth-mac-ecc"; >> + reg = <0xff8c0c00 0x400>; >> + parent = <&gmac0>; >> + interrupts = <5 IRQ_TYPE_LEVEL_HIGH>, >> + <37 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> }; >> -- >> 1.7.9.5 >>