linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/4] clk: max77686: Combine Maxim max77686 and max77802 driver
Date: Fri, 17 Jun 2016 08:01:57 +0200	[thread overview]
Message-ID: <57639255.3010403@samsung.com> (raw)
In-Reply-To: <1466083407-28793-2-git-send-email-ldewangan@nvidia.com>

On 06/16/2016 03:23 PM, Laxman Dewangan wrote:
> The clock IP used on the Maxim PMICs max77686 and max77802 are
> same. The configuration of clock register is also same except
> the number of clocks.
> 
> Part of common code utilisation, there is 3 files for these chips
> clock driver, one for common and two files for driver registration.
> 
> Combine both drivers into single file and move common code into
> same common file reduces the 2 files and make max77686 and max77802
> clock driver in single fine. This driver does not depends on the
> parent driver structure. The regmap handle is acquired through
> regmap APIs for the register access.
> 
> This combination of driver helps on adding clock driver for different
> Maxim PMICs which has similar clock IP like MAX77620 and MAX20024.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@dowhile0.org>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---
> Changes from V1:
> - Collected RB and TB from Javier.
> - Change the max_gen to max77686.
> - Rename structure and avoid duplication for reg and mask.
> - Taken care of comment from Krzysztof on coding.
> ---
>  drivers/clk/Kconfig        |  15 +--
>  drivers/clk/Makefile       |   2 -
>  drivers/clk/clk-max-gen.c  | 194 -----------------------------------
>  drivers/clk/clk-max-gen.h  |  32 ------
>  drivers/clk/clk-max77686.c | 244 ++++++++++++++++++++++++++++++++++++++++++---
>  drivers/clk/clk-max77802.c |  96 ------------------
>  6 files changed, 234 insertions(+), 349 deletions(-)
>  delete mode 100644 drivers/clk/clk-max-gen.c
>  delete mode 100644 drivers/clk/clk-max-gen.h
>  delete mode 100644 drivers/clk/clk-max77802.c


Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

  reply	other threads:[~2016-06-17  6:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 13:23 [PATCH V2 0/4] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan
2016-06-16 13:23 ` [PATCH V2 1/4] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan
2016-06-17  6:01   ` Krzysztof Kozlowski [this message]
2016-06-16 13:23 ` [PATCH V2 2/4] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan
2016-06-16 13:57   ` Javier Martinez Canillas
2016-06-17  5:58   ` Krzysztof Kozlowski
2016-06-16 13:23 ` [PATCH V2 3/4] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan
2016-06-16 14:02   ` Javier Martinez Canillas
2016-06-17  5:59   ` Krzysztof Kozlowski
2016-06-16 13:23 ` [PATCH V2 4/4] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan
2016-06-16 14:07   ` Javier Martinez Canillas
2016-06-17  6:03   ` Krzysztof Kozlowski
2016-06-17  5:53     ` Laxman Dewangan
2016-06-17  6:12       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57639255.3010403@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).