From: tthayer@opensource.altera.com (Thor Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/7] EDAC, altera: Share Arria10 check_deps & IRQ functions
Date: Fri, 17 Jun 2016 12:37:54 -0500 [thread overview]
Message-ID: <57643572.7050805@opensource.altera.com> (raw)
In-Reply-To: <20160617171120.GI3912@pd.tnic>
Hi Boris,
On 06/17/2016 12:11 PM, Borislav Petkov wrote:
> On Fri, Jun 17, 2016 at 12:09:59PM -0500, Thor Thayer wrote:
>> Since each peripheral's EDAC can be individually selected, the build
>> generates a warning of an unused function if just L2 cache was selected.
>>
>> The ifdeffery is ugly but it removes that warning in the L2 only case.
>
> You could add __maybe_unused to the function definition but I guess you
> don't want that code in there if only L2 is selected.
>
> Ok.
>
I like that because otherwise I'll need to add the other peripheral
defines in the future so this will be a multi-line #ifdef
I wasn't aware of that macro but it is much cleaner. I'll use that. Thanks!
next prev parent reply other threads:[~2016-06-17 17:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 21:19 [PATCHv3 0/7] Add Ethernet EDAC & peripheral init functions tthayer at opensource.altera.com
2016-06-13 21:19 ` [PATCHv3 1/7] EDAC, altera: Check parent status for Arria10 EDAC block tthayer at opensource.altera.com
2016-06-17 16:46 ` Borislav Petkov
2016-06-17 16:54 ` Thor Thayer
2016-06-17 16:54 ` Borislav Petkov
2016-06-13 21:19 ` [PATCHv3 2/7] EDAC, altera: Add panic flag check to A10 IRQ tthayer at opensource.altera.com
2016-06-17 16:51 ` Borislav Petkov
2016-06-17 17:05 ` Thor Thayer
2016-06-17 17:02 ` Borislav Petkov
2016-06-17 17:11 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 3/7] EDAC, altera: Share Arria10 check_deps & IRQ functions tthayer at opensource.altera.com
2016-06-17 17:00 ` Borislav Petkov
2016-06-17 17:09 ` Thor Thayer
2016-06-17 17:11 ` Borislav Petkov
2016-06-17 17:37 ` Thor Thayer [this message]
2016-06-13 21:19 ` [PATCHv3 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding tthayer at opensource.altera.com
2016-06-16 18:39 ` Rob Herring
2016-06-16 19:12 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 5/7] EDAC, altera: Add Arria10 ECC memory init functions tthayer at opensource.altera.com
2016-06-17 17:21 ` Borislav Petkov
2016-06-17 17:42 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 6/7] EDAC, altera: Add Arria10 Ethernet EDAC support tthayer at opensource.altera.com
2016-06-17 17:29 ` Borislav Petkov
2016-06-17 17:43 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 7/7] ARM: dts: Add Arria10 Ethernet EDAC devicetree entry tthayer at opensource.altera.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57643572.7050805@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).