From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C54C433EF for ; Fri, 19 Nov 2021 15:55:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C415161549 for ; Fri, 19 Nov 2021 15:55:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C415161549 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/8hGRD8anwvpud1Pibi+kXEQdNYbPKzHFlhxc97IkU8=; b=O7VV+AvVnpw77a CFelI4R75Lf/8+xHuMWZg/eY0Dt5mcx0BWr9wSBqxuCeRkYwbQFp/m7iv1e8IODLZiYubLYbz03bL 0Y9EsjFnh52cKo1MZqZBB0xZcO6T8xIKw1RuMGqc+Kgjt1OTNlMJg2jwMau4elk0eyB8MSOA91kv/ W8QhuYG5x9CBYDrksBHTZ2KhSmI5kjmy72Ts9GUvoQSLfAi3D1OAtf27T/SwJ4IpPhIB8cP5RQk7O oAUzfwCTWhYw3EPDklQ7SsKeVa6gFMtf1VOGxGHta/U0/3ZKSEVnHQf5uPjbePWRVESexi5D83M7x n4P1c0dE9XpwRWduqEQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mo6D0-00AuqQ-AI; Fri, 19 Nov 2021 15:53:50 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mo6Cv-00Aunf-D0 for linux-arm-kernel@lists.infradead.org; Fri, 19 Nov 2021 15:53:47 +0000 Received: by mail-wr1-x435.google.com with SMTP id r8so18867656wra.7 for ; Fri, 19 Nov 2021 07:53:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kHaNRUFisXjYgHBC5B676Xg2I2fpmEyhpkjhdGVDAKM=; b=ZdsrF1YMpdZEaLIT879zO5XP/0/GIL8TxMBkQ+oBsQDHC1XffTe15Xo3zOi3CfQsIW SfVZp4yHJp3z6FO0MsoJXz0l5pt72hEQWvDyTiTNXJ65m72213zH2YphOawDgUHrqFZg tf1fwGadrOC01WL4AAOUCOhNnAIBOhdtZDBp3yH4MwsBVM9OKuO6vgyh1H8JHe9c3xY1 UcZo8yTpxG5QeCXLSEf6W72WVbX+H0+LNvX6UNtwHB7Trtj91sRqcosYwE/7fDXi08aS XGvGFyrXuKCwi0OFOk6jB9JJC6OpJTiJYJKoFXtDW03cMkWwti8iZlRh1DJ1Q3TKYKQR epJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kHaNRUFisXjYgHBC5B676Xg2I2fpmEyhpkjhdGVDAKM=; b=qbO4x4RB/zKyuPlo2vnt//4/Hiztzi7nA0/kQzPyPWOuc1SSgwAm2qwy65HTCn8hCv twbPdnjC90lbQKKWiSITxSVk7v1Gs9vVaau0pEojk1D2mVgsklnfAncHKnhEzl/qQFC4 F4qDbkccM/5c8KbRwbwrdnzFACIqNWCqP4r+VwMiuZtkdN2cwBpKCbwsJd38CNdEFJt8 6JzKh93BLKbbEDE0orVCxv9tQgYtNk2Em55ReN76jEN35UYSy1mjVcMCyqSXkaMVMfnO CD1waZ1HH5K4XCDIhW/m2BJzQRL3QOx3850xR+V1ZEX1522LML2+B3sqe/n3gQVWXzu/ 9Tew== X-Gm-Message-State: AOAM533BbsoocIlfv1LT3bckVEUKDkRm8a7DQL15O4XJFDCJLfB/yIJJ NYMNbFmk4N6G+V1GRsaFm6s= X-Google-Smtp-Source: ABdhPJwoTWQYUCPa9Te8PwG+K8gFrG5i33W0fugyKvlgWtaRFt6efNHW+zbBPrEgEzqCPEArSG3Bvw== X-Received: by 2002:a5d:69ce:: with SMTP id s14mr8340988wrw.25.1637337222991; Fri, 19 Nov 2021 07:53:42 -0800 (PST) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id m2sm12397317wml.15.2021.11.19.07.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 07:53:42 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Paul Kocialkowski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, Samuel Holland Cc: Rob Herring , devicetree@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-staging@lists.linux.dev Subject: Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant Date: Fri, 19 Nov 2021 16:53:41 +0100 Message-ID: <5766379.lOV4Wx5bFT@kista> In-Reply-To: <20211119031519.23430-2-samuel@sholland.org> References: <20211119031519.23430-1-samuel@sholland.org> <20211119031519.23430-2-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211119_075345_471023_4B9A7E18 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Samuel! Dne petek, 19. november 2021 ob 04:15:18 CET je Samuel Holland napisal(a): > D1 has a unique variant of the video engine, which appears to drop the > VP8 support found on most earlier variants. > > Signed-off-by: Samuel Holland > --- > > drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/ media/sunxi/cedrus/cedrus.c > index c76fc97d97a0..4a4b714b0f26 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -580,6 +580,14 @@ static const struct cedrus_variant sun8i_r40_cedrus_variant = { > .mod_rate = 297000000, > }; > > +static const struct cedrus_variant sun20i_d1_cedrus_variant = { > + .capabilities = CEDRUS_CAPABILITY_UNTILED | > + CEDRUS_CAPABILITY_MPEG2_DEC | > + CEDRUS_CAPABILITY_H264_DEC | > + CEDRUS_CAPABILITY_H265_DEC, Did you check if VP8 really doesn't work? It would be strange because it shares decoding blocks with H264 and VP8 is present in (almost) all SoCs. Best regards, Jernej > + .mod_rate = 432000000, > +}; > + > static const struct cedrus_variant sun50i_a64_cedrus_variant = { > .capabilities = CEDRUS_CAPABILITY_UNTILED | > CEDRUS_CAPABILITY_MPEG2_DEC | > @@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = { > .compatible = "allwinner,sun8i-r40-video-engine", > .data = &sun8i_r40_cedrus_variant, > }, > + { > + .compatible = "allwinner,sun20i-d1-video-engine", > + .data = &sun20i_d1_cedrus_variant, > + }, > { > .compatible = "allwinner,sun50i-a64-video-engine", > .data = &sun50i_a64_cedrus_variant, > -- > 2.32.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel