* [PATCH] clk: Fix return value check in oxnas_stdclk_probe()
@ 2016-06-17 17:24 weiyj_lk at 163.com
2016-06-20 10:03 ` Neil Armstrong
2016-06-21 0:00 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: weiyj_lk at 163.com @ 2016-06-17 17:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function syscon_node_to_regmap() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/clk/clk-oxnas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c
index efba7d4..79bcb2e 100644
--- a/drivers/clk/clk-oxnas.c
+++ b/drivers/clk/clk-oxnas.c
@@ -144,9 +144,9 @@ static int oxnas_stdclk_probe(struct platform_device *pdev)
return -ENOMEM;
regmap = syscon_node_to_regmap(of_get_parent(np));
- if (!regmap) {
+ if (IS_ERR(regmap)) {
dev_err(&pdev->dev, "failed to have parent regmap\n");
- return -EINVAL;
+ return PTR_ERR(regmap);
}
for (i = 0; i < ARRAY_SIZE(clk_oxnas_init); i++) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] clk: Fix return value check in oxnas_stdclk_probe()
2016-06-17 17:24 [PATCH] clk: Fix return value check in oxnas_stdclk_probe() weiyj_lk at 163.com
@ 2016-06-20 10:03 ` Neil Armstrong
2016-06-21 0:00 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2016-06-20 10:03 UTC (permalink / raw)
To: linux-arm-kernel
On 06/17/2016 07:24 PM, weiyj_lk at 163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function syscon_node_to_regmap() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/clk/clk-oxnas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c
> index efba7d4..79bcb2e 100644
> --- a/drivers/clk/clk-oxnas.c
> +++ b/drivers/clk/clk-oxnas.c
> @@ -144,9 +144,9 @@ static int oxnas_stdclk_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> regmap = syscon_node_to_regmap(of_get_parent(np));
> - if (!regmap) {
> + if (IS_ERR(regmap)) {
> dev_err(&pdev->dev, "failed to have parent regmap\n");
> - return -EINVAL;
> + return PTR_ERR(regmap);
> }
>
> for (i = 0; i < ARRAY_SIZE(clk_oxnas_init); i++) {
>
>
>
Correct.
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Thanks,
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] clk: Fix return value check in oxnas_stdclk_probe()
2016-06-17 17:24 [PATCH] clk: Fix return value check in oxnas_stdclk_probe() weiyj_lk at 163.com
2016-06-20 10:03 ` Neil Armstrong
@ 2016-06-21 0:00 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-06-21 0:00 UTC (permalink / raw)
To: linux-arm-kernel
On 06/17, weiyj_lk at 163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function syscon_node_to_regmap() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
Applied to clk-fixes + added fixes tag.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-21 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 17:24 [PATCH] clk: Fix return value check in oxnas_stdclk_probe() weiyj_lk at 163.com
2016-06-20 10:03 ` Neil Armstrong
2016-06-21 0:00 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).