From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] arm64: dts: db820c: add basic board support
Date: Tue, 21 Jun 2016 10:14:53 +0100 [thread overview]
Message-ID: <5769058D.9020008@linaro.org> (raw)
In-Reply-To: <57687B08.9060900@codeaurora.org>
On 21/06/16 00:23, Stephen Boyd wrote:
> On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote:
>> This patch adds apq8096 db820c basic support with serial port.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 2 +-
>> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 21 +++++++++++++++++
>> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++
>> 3 files changed, 56 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index fa1f661..80ecdfe 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -1,5 +1,5 @@
>> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb
>> -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb
>
> We should do a new line for each board as other arm64 vendors have done?
I agree, Will fix this in next version.
>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> new file mode 100644 >> +/dts-v1/;
>> +
>> +#include "apq8096-db820c.dtsi"
>> +
>> +/ {
>> + model = "Qualcomm Technologies, Inc. DB820c";
>> + compatible = "qcom,apq8096-db820c";
>
> Should be qcom,apq8096-sbc? At least I have to use that on my board to
> match the board ids.
I agree, this should match up with the dtbTool. I have been manually
patching up dtb to include the board-id, pmic id stuff.
I will fix it in next version,
Did not look at full details but, For some reason dtbTool does not
support multiple compatible strings, do you think it makes sense to add
this support in dtb tool to cope up with compatible strings like:
compatible = "qcom,apq8096-db820c", "qcom,apq8096-sbc";
Thanks,
srini
>
next prev parent reply other threads:[~2016-06-21 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
2016-06-20 23:23 ` Stephen Boyd
2016-06-21 9:14 ` Srinivas Kandagatla [this message]
2016-06-28 17:17 ` Stephen Boyd
2016-06-20 20:01 ` [PATCH 2/8] arm64: dts: db820c: add support to LS-UART0 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 3/8] arm64: dts: db820c: add support to LS-I2C0 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 4/8] arm64: dts: db820c: add support to LS-I2C1 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 5/8] arm64: dts: db820c: add support to I2C on HS Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 6/8] arm64: dts: db820c: add support to LS-SPI0 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 7/8] arm64: dts: db820c: add support to SPI on HS Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
2016-06-20 22:53 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5769058D.9020008@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).